Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cross contract query #40

Merged
merged 5 commits into from
Aug 13, 2024
Merged

Fix/cross contract query #40

merged 5 commits into from
Aug 13, 2024

Conversation

SebastianElvis
Copy link
Member

@SebastianElvis SebastianElvis commented Aug 12, 2024

The current impl based on raw queries is broken. Created #41 to address this in a future iteration / as a future improvement.

Copy link
Collaborator

@maurolacy maurolacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for introducing this raw query stuff without proper testing.

contracts/btc-staking/src/contract.rs Outdated Show resolved Hide resolved
@maurolacy maurolacy changed the title fix cross contract query Fix/cross contract query Aug 12, 2024
@SebastianElvis SebastianElvis marked this pull request as ready for review August 13, 2024 06:19
@SebastianElvis
Copy link
Member Author

Tested under local deployment and babylonlabs-io/babylon-sdk#22. Multitest would probably be added when addressing #41

@SebastianElvis SebastianElvis merged commit e436ae1 into main Aug 13, 2024
1 check passed
@SebastianElvis SebastianElvis deleted the debug-interface branch August 13, 2024 06:23
maurolacy pushed a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants