Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move validation functions to a new mod #58

Merged
merged 3 commits into from
Sep 10, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minor
  • Loading branch information
SebastianElvis committed Sep 9, 2024
commit e6600509732b23daf9d926236453349dbef006d5
2 changes: 0 additions & 2 deletions contracts/btc-staking/src/staking.rs
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,6 @@ pub fn handle_active_delegation(
continue;
}

// TODO?: Skip FPs whose registered epochs are not finalised

// Update staking tx hash by finality provider map
let mut fp_delegations = FP_DELEGATIONS
.may_load(storage, fp_btc_pk_hex)?
Expand Down
1 change: 0 additions & 1 deletion contracts/btc-staking/src/validation/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ pub fn verify_new_fp(_new_fp: &NewFinalityProvider) -> Result<(), ContractError>
#[cfg(feature = "full-validation")]
pub fn verify_new_fp(new_fp: &NewFinalityProvider) -> Result<(), ContractError> {
// get FP's PK

use babylon_apis::new_canonical_addr;
let fp_pk_bytes = hex::decode(&new_fp.btc_pk_hex)
.map_err(|e| ContractError::SecP256K1Error(e.to_string()))?;
Expand Down