chore: update query activated height #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lesterli
requested review from
gitferry,
SebastianElvis,
parketh,
gusin13 and
bap2pecs
bap2pecs
reviewed
Aug 26, 2024
SebastianElvis
approved these changes
Aug 27, 2024
bap2pecs
approved these changes
Aug 28, 2024
bap2pecs
added a commit
to babylonlabs-io/babylon-contract
that referenced
this pull request
Oct 5, 2024
## Summary after babylonlabs-io/finality-provider#42, we no longer need to read activated height from the cw contract. instead, we properly find the time when the first delegation became active (see babylonchain/finality-provider#432) so this cleans up the unused field ## Test Plan ``` cargo optimize cargo precommit cargo integration cargo test ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updated the implementation of activated height which queries the BTC staking activated timestamp via the finality gadget grpc, and then converted it to the L2 block number.
Content babylonchain/finality-provider#432
Test Plan