Fix #108 set comparator to null explicitly to prevent inadventent ref…

…erence to the comparators defined on the prototype
backbone-paginator · Nov 2, 2013 · 8c43178 · 8c43178
1 parent b844a60
commit 8c43178
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/lib/backbone-pageable.js b/lib/backbone-pageable.js
@@ -1315,8 +1315,8 @@
         this.comparator = comparator;
       }
 
-      if (delComp) delete this.comparator;
-      if (delFullComp && fullCollection) delete fullCollection.comparator;
+      if (delComp) this.comparator = null;
+      if (delFullComp && fullCollection) fullCollection.comparator = null;
 
       return this;
     }

diff --git a/test/client-pageable.js b/test/client-pageable.js
@@ -119,8 +119,8 @@ $(document).ready(function () {
     });
 
     strictEqual(col.state.totalRecords, 3);
-    ok(!_.isUndefined(col.fullCollection.comparator));
-    ok(_.isUndefined(col.comparator));
+    ok(col.fullCollection.comparator);
+    ok(!col.comparator);
 
     strictEqual(col.size(), 2);
     strictEqual(col.at(0).get("name"), "a");