-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sidebar below edit form when using multiple languages #59
Comments
@mrlch Can you provide specific steps to reproduce this on a fresh vanilla installation? I tried enabling another language and allowing multilingual options on a content type, but it doesn't cause the same issue: |
I wonder if you have a contrib module that's breaking some things @mrlch -- which contrib modules do you have enabled? |
Today I've encountered the issue with the sidebar moved below the editor on a new multilingual site I'm building. To reproduce the issue, I've set up a fresh demo site, installed the same modules and used the same multilingual options. At first sight without luck, but then I found the thing which makes the difference: a path prefix like If you have enabled URL language detection at To verify the difference, leave the default language without path prefix and add a page using the path |
When I compare the Create page form in the browser dev tools, it looks like the form with the sidebar issue is missing some styles from |
@mrlch and @laryn, I'm curious if you can confirm my findings from two weeks ago:
|
@olafgrabienski I haven't had a chance to verify but it looks like helpful steps to test -- I'll let you know as soon as I'm able to give it a try. |
…l edit pages. Fixes backdrop-contrib#59. Co-authored by: @olafgrabienski Co-authored by: @mrlch
Fixes #59. Co-authored by: @olafgrabienski Co-authored by: @mrlch
@mrlch @olafgrabienski I've made a commit that should take care of this -- thanks for the report and the steps to reproduce! If the fix I've added doesn't solve it for you let me know, but it was all that was needed in my testing to make sure we didn't consider the language code as part of the URL when checking if we were editing a page. |
…tilingual edit pages." This reverts commit 550243c.
@laryn I've tested the commit on one of my sites, and it fixes the issue for me. Thank you! |
I reported in a previous issue that the sidebar is on some installations at the wrong place.
Now I know what causes the issue.
When I install a second language the sidebar moves down.
Editform with only one language installed
Adding second language
Sidebar at the wrong place
go back to one language
Edit form is back at the right place
The text was updated successfully, but these errors were encountered: