Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how the page gets wrapped #78

Closed
laryn opened this issue Dec 8, 2023 · 0 comments · Fixed by #79
Closed

Rework how the page gets wrapped #78

laryn opened this issue Dec 8, 2023 · 0 comments · Fixed by #79

Comments

@laryn
Copy link
Member

laryn commented Dec 8, 2023

Early on as I was experimenting, it seemed some pages needed to be wrapped with the class gin-layer-wrapper to add a background, rounded corners, etc. -- but other pages didn't, such as the main admin content page where the view itself has a background, rounded corners, etc. and I didn't want to double up on those visuals.

At this point my makeshift hardcoded list of pages that need to be wrapped is getting out of control so I'm going to rethink how I'm doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant