Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #9 -Implement hook_config_info() #10

Merged
merged 2 commits into from
Jan 13, 2022
Merged

Issue #9 -Implement hook_config_info() #10

merged 2 commits into from
Jan 13, 2022

Conversation

yorkshire-pudding
Copy link
Collaborator

Implement hook_config_info() so export of config possible in configuration manager

Implement hook_config_info() so export of config possible in configuration manager
tawk_to.module Outdated Show resolved Hide resolved
Replace $info with $prefixes to be consistent with core modules and fixed spacing at beginning of lines
@alvinjohnsonso
Copy link
Collaborator

@yorkshire-pudding would you happen to know if we're able to provide additional details to the exported configuration? We were thinking if we can add the plugin's version to the exported configuration.

@yorkshire-pudding
Copy link
Collaborator Author

yorkshire-pudding commented Jan 13, 2022

@yorkshire-pudding would you happen to know if we're able to provide additional details to the exported configuration? We were thinking if we can add the plugin's version to the exported configuration.

@alvinjohnsonso
We set the config in tawk_to.admin.inc, though there is no need for someone to update config just when they update the module. In theory, we could look at adding elsewhere so it gets updated, but that is a potential overhead as it would write to the config file each time.

As config export is really for ensuring we can move config from one site to another (e.g. dev/stage to production), I'm not clear on what the benefits of exporting the module version would be. That would either be updated on each instance or updated via version control.

If the config function were to add project versions at run time, it would need a change to core.

@yorkshire-pudding yorkshire-pudding merged commit 3f1991f into backdrop-contrib:1.x-1.x Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration of tawk.to module not available for export
2 participants