Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and tests #64

Merged
merged 4 commits into from
Jan 3, 2019
Merged

Update dependencies and tests #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
332e274
Added lock file to gitignore
Jan 3, 2019
347fcd8
Updated Travis config
Jan 3, 2019
bdf485f
Removed lock file
backflip Jan 3, 2019
d0e9882
Updated code, dependencies and tests
backflip Jan 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
.DS_Store
node_modules
test/results*
npm-debug.log
npm-debug.log
package-lock.json
4 changes: 3 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
language: node_js
node_js:
- 0.10
- 6
- 8
- 10

script:
- npm test
9 changes: 2 additions & 7 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ function iconfontCSS(config) {
base: file.base,
cwd: file.cwd,
path: path.join(file.base, config.targetPath),
contents: file.isBuffer() ? new Buffer(0) : new Stream.PassThrough()
contents: file.isBuffer() ? Buffer.alloc(0) : new Stream.PassThrough()
});
}

Expand Down Expand Up @@ -127,12 +127,7 @@ function iconfontCSS(config) {
throw new PluginError(PLUGIN_NAME, 'Error in template: ' + err.message);
}

// TODO: remove condition and the else block for version 3.0
if( Buffer.from ){
content = Buffer.from(html);
}else{
content = Buffer(html);
}
content = Buffer.from(html);

if (outputFile.isBuffer()) {
outputFile.contents = content;
Expand Down
Loading