Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mend - Remove private flag #1841

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Conversation

dariuszsobkowicz
Copy link
Contributor

@dariuszsobkowicz dariuszsobkowicz commented Nov 6, 2024

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Darius <dariusz.sobkowicz@gmail.com>
@dariuszsobkowicz dariuszsobkowicz requested a review from a team as a code owner November 6, 2024 06:03
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Nov 6, 2024

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-mend-backend workspaces/mend/plugins/mend-backend minor v0.0.0
@backstage-community/plugin-mend workspaces/mend/plugins/mend minor v0.0.0

Signed-off-by: Darius <dariusz.sobkowicz@gmail.com>
Comment on lines 2 to 3
'@backstage-community/plugin-mend-backend': patch
'@backstage-community/plugin-mend': patch
Copy link
Member

@christoph-jerolimov christoph-jerolimov Nov 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because your current version is 0.1.0, this will release a 0.1.1. Is this what you expect?

If you want to release 0.1.0, you should change the package.json version to 0.0.0 and this changeset to minor (or major if you want to start directly with 1.0.0).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated to release version 0.1.0

Signed-off-by: Darius <dariusz.sobkowicz@gmail.com>
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 2 to 6
'@backstage-community/plugin-mend-backend': minor
'@backstage-community/plugin-mend': minor
---

Enable NPM publishing by removing private flag.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and then another changeset for @backstage-community/plugin-mend

Suggested change
'@backstage-community/plugin-mend-backend': minor
'@backstage-community/plugin-mend': minor
---
Enable NPM publishing by removing private flag.
'@backstage-community/plugin-mend-backend': minor
---
Initial release of the `@backstage-community/plugin-mend-backend` plugin.

Signed-off-by: Darius <dariusz.sobkowicz@gmail.com>
Signed-off-by: Darius <dariusz.sobkowicz@gmail.com>
@vinzscam vinzscam merged commit 898b5f1 into backstage:main Nov 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants