Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add additional codeowners for acr, ocm and rbac workspaces #1850

Conversation

christoph-jerolimov
Copy link
Member

Hey, I just made a Pull Request!

This PR adds additional codeowners for plugins we (Red Hat) converted/migrated the last month from Janus IDP to this Backstage community-plugins repo

  1. @christoph-jerolimov / myself for the acr workspace (Azure Container Registry) where just @invincibleJai is a codeowner at the moment who is not part of the Backstage org yet. Jai, maybe you can approve that PR anyway to show your acknowledge on this.

    I worked already on some acr improvements and have some more local changes:

  2. @christoph-jerolimov / myself also for the ocm (Open Cluster Management) workspace where just @debsmita1 is a codeowner at the moment who is not part of the Backstage org yet. Debsmita, maybe you can approve that PR anyway to show your acknowledge on this.

    Until now, I have raised just this small PR on that workspace.

  3. @divyanshiGupta to the rbac workspace as she was responsible for the RBAC frontend plugin in the past.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
@debsmita1
Copy link

/lgtm

1 similar comment
@invincibleJai
Copy link

/lgtm

@nickboldt nickboldt merged commit 9b1f68c into backstage:main Nov 6, 2024
8 checks passed
kajahanne pushed a commit to kajahanne/community-plugins that referenced this pull request Nov 6, 2024
…ckstage#1850)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>
@christoph-jerolimov christoph-jerolimov deleted the update-acr-ocm-rbac-code-owners branch November 6, 2024 14:13
kajahanne pushed a commit to kajahanne/community-plugins that referenced this pull request Nov 11, 2024
…ckstage#1850)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>
kajahanne pushed a commit to kajahanne/community-plugins that referenced this pull request Nov 11, 2024
…ckstage#1850)

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
Signed-off-by: Kaja Hannestad <kaja.hannestad@vipps.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants