Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search config example in community-plugins/workspaces/confluence/… #2811

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

tplass-ias
Copy link
Contributor

@tplass-ias tplass-ias commented Feb 4, 2025

…plugins/search-backend-module-confluence-collator/README.md

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@tplass-ias tplass-ias requested a review from a team as a code owner February 4, 2025 22:26
@tplass-ias tplass-ias requested a review from 04kash February 4, 2025 22:26
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Feb 4, 2025

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-search-backend-module-confluence-collator workspaces/confluence/plugins/search-backend-module-confluence-collator patch v0.4.0

Copy link
Member

@04kash 04kash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tplass-ias!

You'll also need to add a changeset so that the changes are reflected in NPM as well. You can take a look at the docs here on details regarding how to do that

…plugins/search-backend-module-confluence-collator/README.md

Signed-off-by: Tyler Plass <tplass@integralads.com>
@tplass-ias
Copy link
Contributor Author

@04kash updated :)

Copy link
Member

@04kash 04kash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@04kash 04kash enabled auto-merge (squash) February 5, 2025 18:48
@04kash 04kash merged commit 0a80de6 into backstage:main Feb 5, 2025
11 checks passed
harmenbrinkmanTRIMM pushed a commit to harmenbrinkmanTRIMM/community-plugins that referenced this pull request Feb 19, 2025
…plugins/search-backend-module-confluence-collator/README.md (backstage#2811)

Signed-off-by: Tyler Plass <tplass@integralads.com>
Signed-off-by: Harmen Brinkman <harmen.brinkman@trimm.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants