Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python to 3.12 (latest) #67

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

heyLu
Copy link
Contributor

@heyLu heyLu commented Apr 15, 2024

Python 3.8 is a bit old at this point and a couple of dependencies already require Python 3.10, making the current image incompatible.

One examples is https://github.com/AVATEAM-IT-SYSTEMHAUS/mkdocs-kroki-plugin/blob/main/setup.py#L20, which my employer uses internally and thus we need a Python version update to be able to use the latest version of that plugin.

Python 3.8 is a bit old at this point and a couple of dependencies
already require Python 3.10, making the current image incompatible.

One examples is https://github.com/AVATEAM-IT-SYSTEMHAUS/mkdocs-kroki-plugin/blob/main/setup.py#L20,
which my employer uses internally and thus we need a Python version
update to be able to use the latest version of that plugin.
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label Apr 30, 2024
@heyLu
Copy link
Contributor Author

heyLu commented May 2, 2024

@PeaWarrior or @squid-ney, could you have a look at this?

@github-actions github-actions bot removed the stale label May 3, 2024
Copy link

This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution!

@github-actions github-actions bot added the stale label May 17, 2024
@heyLu
Copy link
Contributor Author

heyLu commented May 21, 2024

Trying again, @awanlin, can you review this or pass this along to someone who can?

Copy link
Collaborator

@awanlin awanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @heyLu, looks good to me 🚀

@alexlorenzi
Copy link
Contributor

Thanks for contribution @heyLu

@alexlorenzi alexlorenzi merged commit e61e092 into backstage:main May 21, 2024
@heyLu heyLu deleted the update-python branch May 22, 2024 09:04
@heyLu
Copy link
Contributor Author

heyLu commented May 22, 2024

@alexlorenzi will there be a release for this and other changes since the last release? Upstream seems to use the current release from last August, but an updated release would be nice I think. (Or should we use the automatically built non-tagged images pushed by CI?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants