Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restic restore run cmd separately to capture error #1005

Merged
merged 1 commit into from
Nov 29, 2023
Merged

restic restore run cmd separately to capture error #1005

merged 1 commit into from
Nov 29, 2023

Conversation

tesshuflower
Copy link
Contributor

@tesshuflower tesshuflower commented Nov 28, 2023 •
edited
Loading

Describe what this PR does

Is there anything that requires special attention?

Related issues:
#1004

@tesshuflower
restic restore run cmd separately to capture error
ab3811c 
Signed-off-by: Tesshu Flower <tflower@redhat.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@tesshuflower
Copy link
Contributor Author

/cc @JohnStrunk

JohnStrunk
JohnStrunk approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@JohnStrunk JohnStrunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 29, 2023
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Nov 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnStrunk, tesshuflower

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [JohnStrunk,tesshuflower]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tesshuflower
Copy link
Contributor Author

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 7dd3dc1 into backube:main Nov 29, 2023
33 checks passed
@tesshuflower
Copy link
Contributor Author

/cherry-pick release-0.8

@tesshuflower tesshuflower deleted the restic_dest_job_errhandling branch November 30, 2023 13:47
@openshift-cherrypick-robot
Copy link

@tesshuflower: new pull request created: #1009

In response to this:

/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 30, 2023
Merged
@tesshuflower tesshuflower mentioned this pull request Dec 19, 2023
Closed
@tesshuflower tesshuflower mentioned this pull request Feb 26, 2024
Closed
@tesshuflower tesshuflower mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnStrunk JohnStrunk JohnStrunk approved these changes

Assignees

@JohnStrunk JohnStrunk

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tesshuflower @openshift-cherrypick-robot @JohnStrunk