build error on ubuntu 24.04

[bakaiadam]

Describe the bug
cmake runs fine, make runs into error:

/home/adam/snapcast/common/resampler.cpp: In constructor ‘Resampler::Resampler(const SampleFormat&, const SampleFormat&)’: /home/adam/snapcast/common/resampler.cpp:64:15: error: ‘SnapException’ was not declared in this scope 64 | throw SnapException("Resampling requested, but not supported"); | ^~~~~~~~~~~~~ make[2]: *** [common/CMakeFiles/common.dir/build.make:76: common/CMakeFiles/common.dir/resampler.cpp.o] Error 1 make[1]: *** [CMakeFiles/Makefile2:161: common/CMakeFiles/common.dir/all] Error 2 make: *** [Makefile:136: all] Error 2

The command is:
cd /home/adam/snapcast/common && /usr/bin/c++ -DBOOST_ASIO_NO_TS_EXECUTORS -DBOOST_ERROR_CODE_HEADER_ONLY -DHAS_ALSA -DHAS_AVAHI -DHAS_DAEMON -DHAS_EXPAT -DHAS_FLAC -DHAS_JACK -DHAS_OGG -DHAS_OPUS -DHAS_PULSE -DVERSION=\"0.29.0\" -I/home/adam/snapcast -I/home/adam/snapcast/include -std=gnu++17 -Wall -Wextra -pedantic -Wno-unused-function -MD -MT common/CMakeFiles/common.dir/resampler.cpp.o -MF CMakeFiles/common.dir/resampler.cpp.o.d -o CMakeFiles/common.dir/resampler.cpp.o -c /home/adam/snapcast/common/resampler.cpp

c++ version is:

c++ (Ubuntu 13.2.0-23ubuntu4) 13.2.0 Copyright (C) 2023 Free Software Foundation, Inc.

[j12i]

I got the same error tring to compile on Slackware64 15.0.

[Will9982890]

Created a patch to fix the build. Not familiar enough with github for a pull request and it seems that the file attach doesn't like the patch file, so here's a code block for the patch itself:

https://www.linuxquestions.org/questions/slackware-14/building-snapcast-fails-4175743846-print/
Fix due to error in compile
FAILED: common/CMakeFiles/common.dir/resampler.cpp.o
   64 |         throw SnapException("Resampling requested, but not supported");
      |               ^~~~~~~~~~~~~
--- a/common/resampler.cpp	2024-08-23 04:06:51.000000000 -0400
+++ b/common/resampler.cpp	2024-12-08 16:03:27.479309965 -0500
@@ -21,6 +21,7 @@
 
 // local headers
 #include "common/aixlog.hpp"
+#include "common/snap_exception.hpp"
 
 // standard headers
 #include <cmath>

It works for me.

[badaix]

Thanks @Will9982890
Should be solved now in develop branch: f6ce4f3

[j12i]

Could you make a 0.29.1 release with this patch please? Seeing that 0.29.0 is broken. I'd rather keep relying on releases for my packaging than switch to commits.