Add Airplay cover art to metadata #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badaix
reviewed
Feb 25, 2020
| // operation. When the memory is no longer available, the buffer is said to have been invalidated. | ||
| // https://www.boost.org/doc/libs/1_72_0/doc/html/boost_asio/reference/buffer.html#boost_asio.reference.buffer.buffer_invalidation | ||
|
|
||
| string& message = messages_.front(); |
There was a problem hiding this comment.
this bug is a nasty one, great that you found it. But it's not related to the metadata, right? It looks like meta data is sent to the streaming clients, and not to the control clients.
Also I think, I would prefer adding the \r\n when adding the message to the queue:
void ControlSessionTcp::sendAsync(const std::string& message)
{
strand_.post([ this, self = shared_from_this(), message ]() {
messages_.emplace_back(message + "\r\n");There was a problem hiding this comment.
Thank you for merging!
While the code may not be related to the metadata handling, the issue only surfaced when I sent big metadata cover images. I assume that the the big metadata strings resulted in a different/more rapidly changing/... stack/heap, causing the undefined behavior created by this bug to actually do something bad (crash the control server).
| #endif | ||
|
|
||
| void pipeReadLine(); | ||
| #ifdef HAS_EXPAT | ||
| int parse(std::string line); | ||
| void createParser(); | ||
| void push(); | ||
| void setMetaData(const std::string&, const std::string&); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new "COVER" attribute to the metadata, which is supported by Airplay and contains the base64 encoded cover.
To make it work, I also had to fix an issue with the control session handler which would sometimes produce 'Bad address' errors (particularly with large covers).
I have documented more details in the comments I added.