Skip to content

Commit

Permalink
Revert "Filter away specs found in node_modules"
Browse files Browse the repository at this point in the history
This was recently fixed in `find-cypress-specs` [1].

[1] bahmutov/find-cypress-specs#302
  • Loading branch information
badeball committed Sep 22, 2024
1 parent dc82cfa commit 53f4049
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 58 deletions.
4 changes: 2 additions & 2 deletions lib/add-cucumber-preprocessor-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ import parse from "@cucumber/tag-expressions";

import { generateMessages } from "@cucumber/gherkin";

import { getSpecs } from "find-cypress-specs";

import { INTERNAL_PROPERTY_NAME, INTERNAL_SUITE_PROPERTIES } from "./constants";

import {
Expand Down Expand Up @@ -46,8 +48,6 @@ import { assertNever } from "./helpers/assertions";

import debug from "./helpers/debug";

import { getSpecs } from "./helpers/specs";

const resolve = memoize(origResolve);

export type AddOptions = {
Expand Down
2 changes: 1 addition & 1 deletion lib/diagnostics/diagnose.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import fs from "fs/promises";
import path from "path";
import util from "util";
import { getSpecs } from "find-cypress-specs";
import {
Expression,
ParameterTypeRegistry,
Expand Down Expand Up @@ -28,7 +29,6 @@ import {
getStepDefinitionPaths,
} from "../step-definitions";
import { notNull } from "../helpers/type-guards";
import { getSpecs } from "../helpers/specs";

export interface DiagnosticStep {
source: string;
Expand Down
52 changes: 0 additions & 52 deletions lib/helpers/specs.ts

This file was deleted.

4 changes: 2 additions & 2 deletions lib/template.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import { generateMessages } from "@cucumber/gherkin";

import { IdGenerator, SourceMediaType } from "@cucumber/messages";

import { getSpecs } from "find-cypress-specs";

import ancestor from "common-ancestor-path";

import { assertAndReturn } from "./helpers/assertions";
Expand All @@ -27,8 +29,6 @@ import debug from "./helpers/debug";

import type { CreateTestsOptions } from "./browser-runtime";

import { getSpecs } from "./helpers/specs";

const { stringify } = JSON;

export async function compile(
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"cosmiconfig": "^9.0.0",
"debug": "^4.3.6",
"error-stack-parser": "^2.1.4",
"find-cypress-specs": "^1.45.1",
"find-cypress-specs": "^1.45.2",
"glob": "^10.4.5",
"is-path-inside": "^3.0.3",
"mocha": "^10.7.0",
Expand Down

0 comments on commit 53f4049

Please sign in to comment.