forked from Klaveness-Digital/cypress-cucumber-preprocessor
-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
preprocessor reads same steps.ts
file for each step defined in it after v21
#1245
Closed
3 tasks done
Comments
Hey @mysticdevx, thanks for the heads up, this has been fixed with v21.0.2. |
Hi @badeball , I confirm the issue is resolved on my end too. Thanks |
This was referenced Oct 4, 2024
Closed
stalwartstu
pushed a commit
to ministryofjustice/hmpps-digital-prison-reporting-mi-ui
that referenced
this issue
Oct 21, 2024
) Bumps [@badeball/cypress-cucumber-preprocessor](https://github.com/badeball/cypress-cucumber-preprocessor) from 20.1.2 to 21.0.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/badeball/cypress-cucumber-preprocessor/releases"><code>@badeball/cypress-cucumber-preprocessor</code>'s releases</a>.</em></p> <blockquote> <h2>v21.0.2</h2> <ul> <li>Cache requested source maps, fixes <a href="https://github.com/badeball/cypress-cucumber-preprocessor/discussions/1245">#1245</a>.</li> </ul> <h2>v21.0.1</h2> <ul> <li>Support config file locations other than project root, fixes <a href="https://github.com/badeball/cypress-cucumber-preprocessor/discussions/1243">#1243</a>.</li> </ul> <h2>v21.0.0</h2> <p>Breaking changes:</p> <ul> <li> <p>Exported member <code>preprocessor</code> of <code>@badeball/cypress-cucumber-preprocessor/browserify</code> is removed.</p> <ul> <li>User of <code>@badeball/cypress-cucumber-preprocessor/browserify</code> should change their Cypress config in accordance with the related <a href="https://github.com/badeball/cypress-cucumber-preprocessor/blob/HEAD/examples">https://github.com/badeball/cypress-cucumber-preprocessor/blob/HEAD/examples</a>.</li> </ul> </li> <li> <p>The executable <code>cypress-cucumber-diagnostics</code> has been replaced by a <a href="https://github.com/badeball/cypress-cucumber-preprocessor/blob/HEAD/docs/dry-run.md"><code>dryRun</code> option</a>, relates to <a href="https://github.com/badeball/cypress-cucumber-preprocessor/issues/1120">#1120</a> and <a href="https://github.com/badeball/cypress-cucumber-preprocessor/issues/1129">#1129</a>.</p> <ul> <li>This is a massive overhaul of a feature that was originally ill-thought-out. I'm curious about the reception.</li> </ul> </li> </ul> <p>Other changees:</p> <ul> <li> <p>Re-introduce support for Node v18, fixes <a href="https://github.com/badeball/cypress-cucumber-preprocessor/discussions/1230">#1230</a>.</p> </li> <li> <p>Generate a temporary messages report in case of <code>JsonFormatter</code> errors, relates to <a href="https://github.com/badeball/cypress-cucumber-preprocessor/issues/1161">#1161</a>.</p> </li> <li> <p>Support project directories containing square brackets, EG. <code>/home/[foo] my project/</code>, relates to <a href="https://github.com/badeball/cypress-cucumber-preprocessor/discussions/1196">#1196</a>.</p> </li> <li> <p>Allow features in arbitrary locations, fixes <a href="https://github.com/badeball/cypress-cucumber-preprocessor/issues/1225">#1225</a>.</p> </li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/badeball/cypress-cucumber-preprocessor/blob/master/CHANGELOG.md"><code>@badeball/cypress-cucumber-preprocessor</code>'s changelog</a>.</em></p> <blockquote> <h2>v21.0.2</h2> <ul> <li>Cache requested source maps, fixes <a href="https://github.com/badeball/cypress-cucumber-preprocessor/discussions/1245">#1245</a>.</li> </ul> <h2>v21.0.1</h2> <ul> <li>Support config file locations other than project root, fixes <a href="https://github.com/badeball/cypress-cucumber-preprocessor/discussions/1243">#1243</a>.</li> </ul> <h2>v21.0.0</h2> <p>Breaking changes:</p> <ul> <li> <p>Exported member <code>preprocessor</code> of <code>@badeball/cypress-cucumber-preprocessor/browserify</code> is removed.</p> <ul> <li>User of <code>@badeball/cypress-cucumber-preprocessor/browserify</code> should change their Cypress config in accordance with the related <a href="https://github.com/badeball/cypress-cucumber-preprocessor/blob/master/examples">https://github.com/badeball/cypress-cucumber-preprocessor/blob/master/examples</a>.</li> </ul> </li> <li> <p>The executable <code>cypress-cucumber-diagnostics</code> has been replaced by a <a href="https://github.com/badeball/cypress-cucumber-preprocessor/blob/master/docs/dry-run.md"><code>dryRun</code> option</a>, relates to <a href="https://github.com/badeball/cypress-cucumber-preprocessor/issues/1120">#1120</a> and <a href="https://github.com/badeball/cypress-cucumber-preprocessor/issues/1129">#1129</a>.</p> <ul> <li>This is a massive overhaul of a feature that was originally ill-thought-out. I'm curious about the reception.</li> </ul> </li> </ul> <p>Other changees:</p> <ul> <li> <p>Re-introduce support for Node v18, fixes <a href="https://github.com/badeball/cypress-cucumber-preprocessor/discussions/1230">#1230</a>.</p> </li> <li> <p>Generate a temporary messages report in case of <code>JsonFormatter</code> errors, relates to <a href="https://github.com/badeball/cypress-cucumber-preprocessor/issues/1161">#1161</a>.</p> </li> <li> <p>Support project directories containing square brackets, EG. <code>/home/[foo] my project/</code>, relates to <a href="https://github.com/badeball/cypress-cucumber-preprocessor/discussions/1196">#1196</a>.</p> </li> <li> <p>Allow features in arbitrary locations, fixes <a href="https://github.com/badeball/cypress-cucumber-preprocessor/issues/1225">#1225</a>.</p> </li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/badeball/cypress-cucumber-preprocessor/commit/ffe6808cc4062f12b254aca964fd9855b0026ca5"><code>ffe6808</code></a> v21.0.2</li> <li><a href="https://github.com/badeball/cypress-cucumber-preprocessor/commit/8acb238d1ea51875e14d42b29d035c3a4a6d7a47"><code>8acb238</code></a> Cache requested source maps</li> <li><a href="https://github.com/badeball/cypress-cucumber-preprocessor/commit/1e11dca6bec89b529153bc6ea7a4d81b437bbd37"><code>1e11dca</code></a> v21.0.1</li> <li><a href="https://github.com/badeball/cypress-cucumber-preprocessor/commit/10423a831201b44bbe49c586f906ec2e582fbdfb"><code>10423a8</code></a> Support config file locations other than project root</li> <li><a href="https://github.com/badeball/cypress-cucumber-preprocessor/commit/a8b0926a3f32c846413500a07d0ea7219b566da5"><code>a8b0926</code></a> Less noisy renovate bot</li> <li><a href="https://github.com/badeball/cypress-cucumber-preprocessor/commit/931ec882cce93703ee71c3cfa7d06cb65478a54d"><code>931ec88</code></a> Update dependency <code>@cucumber/messages</code> to v26</li> <li><a href="https://github.com/badeball/cypress-cucumber-preprocessor/commit/a3fa7cc229389bfb2d89a72e5dbcecd1311b96f0"><code>a3fa7cc</code></a> Update dependency <code>@cucumber/gherkin</code> to v29</li> <li><a href="https://github.com/badeball/cypress-cucumber-preprocessor/commit/2c5d05d379f94849baede4eb58e4bb61036f6c11"><code>2c5d05d</code></a> Update dependency <code>@cucumber/cucumber</code> to v11</li> <li><a href="https://github.com/badeball/cypress-cucumber-preprocessor/commit/d26bdba408e073dcf07753b63ad8b5f4dfd2c72f"><code>d26bdba</code></a> Avoid multiple runs on renovate bot's PRs</li> <li><a href="https://github.com/badeball/cypress-cucumber-preprocessor/commit/a16cf61afdd58249d8d99352525bcd25acf38759"><code>a16cf61</code></a> Merge pull request <a href="https://github.com/badeball/cypress-cucumber-preprocessor/issues/1234">#1234</a> from badeball/renovate/configure</li> <li>Additional commits viewable in <a href="https://github.com/badeball/cypress-cucumber-preprocessor/compare/v20.1.2...v21.0.2">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@badeball/cypress-cucumber-preprocessor&package-manager=npm_and_yarn&previous-version=20.1.2&new-version=21.0.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Oct 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current behavior
As of v21.0.0, when I run a single .feature file, test doesn't start. It keeps like compiling the test files, and in console the preprocessor SEEMs in an infinite loop in logging
GET /__cypress/tests?p=cypress/integration/common/path/to/test.feature
When I investigate in a minimal repo (see link below), I saw that the number of logs are same as the step definitions. I.e, if the
stepDefinitions: ["cypress/e2e/steps/**/*.ts"]
setting resolves 10.steps.ts
files, having 10 step implementations in each, the loop continues for 100 times. Therefore when the framework, and number of tests grow, the loop and wait time seems infinite. (possibly related to the recent this #1243 issue)I compared the behaviour with v20.1.2 thats not the case. See sample console log.
Desired behavior
As in the prior v21, the number of steps in step files should not cause the loop.
Test code to reproduce
You can see a basic repo here: https://github.com/mysticdevx/cucumber-basic/tree/latest-version
Versions
Checklist
cypress-cucumber-preprocessor@4.3.1
(package name has changed and it is no longer the most recent version, see #689).The text was updated successfully, but these errors were encountered: