Add missing textarea attributes #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restored parsing of minLength and maxLength for use in input and textarea fields.
|
@dayre I must have missed this the first time, but why were these attributes added to HiddenField as well? |
|
@dayre Just in case you're interested, i think the failing tests were due to a new Node 18 bug: nodejs/undici#1433 |
|
Re the hidden field addtions... my mistake... I was referencing the RFC for minlength/maxlength attributes being used for input and textarea fields. I didn't look at specifically at the section on inputs for type=hidden which does say they must not be specified and do not apply: https://www.w3.org/TR/2014/CR-html5-20140429/forms.html#hidden-state-(type=hidden) |
Removed minLength/maxLength attributes for input type=hidden per RFC
Removed minlength/maxlength from input type=hidden per RFC
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR as nodejs/node#439, but applied to the stable version-7.x branch