Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

Commit

Permalink
Travis builds: brightgreen.
Browse files Browse the repository at this point in the history
  • Loading branch information
@espadrine
espadrine committed Jan 22, 2014
1 parent 2c1880e commit 0ecb22f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion server.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ function(data, match, end, ask) {
var state = statusMatch[1];
badgeData.text[1] = state;
if (state === 'passing') {
badgeData.colorscheme = 'green';
badgeData.colorscheme = 'brightgreen';
} else if (state === 'failing') {
badgeData.colorscheme = 'red';
}
Expand Down

6 comments on commit 0ecb22f

@jmalloc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh noes, change it back! :P
Or at least update the other services "OK" status to match (coveralls) ;)

@espadrine
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! (all other services match.)

@ezzatron
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing a difference between coveralls 100% coverage, and travis build passing colours. Travis is brightgreen, but Coveralls is just regular green, even though coverage is 100%. See https://github.com/eloquent/blox for example.

@espadrine
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezzatron It's deployed now.

Btw, I'm switching to img.shields.io. b.adge.me will still be up (and up-to-date) for a year, but I believe it has problems with HTTPS.

@ezzatron
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, although, for the record, Chrome doesn't seem to like the cert for img.shields.io either :/

@espadrine
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. I thought they had something for SSL. Noticed that today. Turns out they filed the bug: badges/shields#66.

Please sign in to comment.