fix formatRelativeDate error handling; run [date] (#8497)

Co-authored-by: repo-ranger[bot] <39074581+repo-ranger[bot]@users.noreply.github.com>
badges · Oct 8, 2022 · 8f4662b · 8f4662b
1 parent d78a2f4
commit 8f4662b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/services/text-formatters.js b/services/text-formatters.js
@@ -124,9 +124,11 @@ function formatDate(d) {
 }
 
 function formatRelativeDate(timestamp) {
-  return dayjs()
-    .to(dayjs.unix(parseInt(timestamp, 10)))
-    .toLowerCase()
+  const parsedDate = dayjs.unix(parseInt(timestamp, 10))
+  if (!parsedDate.isValid()) {
+    return 'invalid date'
+  }
+  return dayjs().to(parsedDate).toLowerCase()
 }
 
 export {

diff --git a/services/text-formatters.spec.js b/services/text-formatters.spec.js
@@ -153,5 +153,11 @@ describe('Text formatters', function () {
         .describe('when given the beginning of october')
         .expect('a month ago')
     })
+
+    test(formatRelativeDate, () => {
+      given(9999999999999)
+        .describe('when given invalid date')
+        .expect('invalid date')
+    })
   })
 })