Fix regression with double-dash escaping in [StaticBadge] (#2367)

Fix #2366
badges · Nov 19, 2018 · b922fca · b922fca
1 parent 6305c59
commit b922fca
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/services/static-badge/static-badge.service.js b/services/static-badge/static-badge.service.js
@@ -1,6 +1,7 @@
 'use strict'
 
 const BaseStaticService = require('../base-static')
+const { escapeFormat } = require('../../lib/path-helpers')
 
 module.exports = class StaticBadge extends BaseStaticService {
   static get category() {
@@ -15,6 +16,6 @@ module.exports = class StaticBadge extends BaseStaticService {
   }
 
   handle({ label, message, color }) {
-    return { label, message, color }
+    return { label: escapeFormat(label), message: escapeFormat(message), color }
   }
 }
diff --git a/services/static-badge/static-badge.tester.js b/services/static-badge/static-badge.tester.js
@@ -31,6 +31,14 @@ t.create('Missing label')
   .get('/badge/-message-blue.json?style=_shields_test')
   .expectJSON({ name: '', value: 'message', colorB: '#007ec6' })
 
+t.create('Case is preserved')
+  .get('/badge/LiCeNsE-mIt-blue.json?style=_shields_test')
+  .expectJSON({ name: 'LiCeNsE', value: 'mIt', colorB: '#007ec6' })
+
+t.create('"Shields-encoded" dash')
+  .get('/badge/best--license-Apache--2.0-blue.json?style=_shields_test')
+  .expectJSON({ name: 'best-license', value: 'Apache-2.0', colorB: '#007ec6' })
+
 t.create('Override colorB')
   .get('/badge/label-message-blue.json?style=_shields_test&colorB=yellow')
   .expectJSON({ name: 'label', value: 'message', colorB: '#dfb317' })