chore: add links array lenght validation

badges · Jun 11, 2024 · c1774f0 · c1774f0
1 parent 6110f58
commit c1774f0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/badge-maker/lib/index.js b/badge-maker/lib/index.js
@@ -34,6 +34,11 @@ function _validate(format) {
     if (!Array.isArray(format.links)) {
       throw new ValidationError('Field `links` must be an array of strings')
     } else {
+      if (format.links.length > 2) {
+        throw new ValidationError(
+          'Field `links` must not have more than 2 elements',
+        )
+      }
       format.links.forEach(function (field) {
         if (typeof field !== 'string') {
           throw new ValidationError('Field `links` must be an array of strings')

diff --git a/badge-maker/lib/index.spec.js b/badge-maker/lib/index.spec.js
@@ -70,6 +70,12 @@ describe('makeBadge function', function () {
     expect(() =>
       makeBadge({ label: 'build', message: 'passed', links: [1] }),
     ).to.throw(ValidationError, 'Field `links` must be an array of strings')
+    expect(() =>
+      makeBadge({ label: 'build', message: 'passed', links: ['1', '2', '3'] }),
+    ).to.throw(
+      ValidationError,
+      'Field `links` must not have more than 2 elements',
+    )
     expect(() =>
       makeBadge({ label: 'build', message: 'passed', format: 'png' }),
     ).to.throw(ValidationError, "Unexpected field 'format'")