feat(endpoint-badge): add logoSize support

badges · May 2, 2024 · d1c8667 · d1c8667
1 parent 1ab4a8d
commit d1c8667
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 0 deletions.
diff --git a/core/base-service/base.js b/core/base-service/base.js
@@ -65,6 +65,7 @@ const serviceDataSchema = Joi.object({
   namedLogo: Joi.string(),
   logoSvg: Joi.string(),
   logoColor: optionalStringWhenNamedLogoPresent,
+  logoSize: optionalStringWhenNamedLogoPresent,
   logoWidth: optionalNumberWhenAnyLogoPresent,
   logoPosition: optionalNumberWhenAnyLogoPresent,
   cacheSeconds: Joi.number().integer().min(0),

diff --git a/services/endpoint-common.js b/services/endpoint-common.js
@@ -35,6 +35,7 @@ const endpointSchema = Joi.object({
   namedLogo: Joi.string(),
   logoSvg: Joi.string(),
   logoColor: optionalStringWhenNamedLogoPresent,
+  logoSize: optionalStringWhenNamedLogoPresent,
   logoWidth: optionalNumberWhenAnyLogoPresent,
   logoPosition: optionalNumberWhenAnyLogoPresent,
   style: Joi.string(),

diff --git a/services/endpoint/endpoint.service.js b/services/endpoint/endpoint.service.js
@@ -95,6 +95,14 @@ The endpoint badge takes a single required query param: <code>url</code>, which
           named logo will be used and colored.
         </td>
       </tr>
+      <tr>
+      <td><code>logoSize</code></td>
+      <td>
+        Default: none. Make icons adaptively resize by setting auto.
+        Useful for some wider logos like <code>amd</code> and <code>amg</code>.
+        Supported for simple-icons logos only.
+      </td>
+    </tr>
       <tr>
         <td><code>logoWidth</code></td>
         <td>
@@ -156,6 +164,7 @@ export default class Endpoint extends BaseJsonService {
     namedLogo,
     logoSvg,
     logoColor,
+    logoSize,
     logoWidth,
     logoPosition,
     style,
@@ -170,6 +179,7 @@ export default class Endpoint extends BaseJsonService {
       namedLogo,
       logoSvg,
       logoColor,
+      logoSize,
       logoWidth,
       logoPosition,
       style,

diff --git a/services/endpoint/endpoint.tester.js b/services/endpoint/endpoint.tester.js
@@ -82,6 +82,22 @@ t.create('named logo with color')
     expect(body).to.include(getSimpleIcon({ name: 'github', color: 'blue' }))
   })
 
+t.create('named logo with size')
+  .get('.svg?url=https://example.com/badge')
+  .intercept(nock =>
+    nock('https://example.com/').get('/badge').reply(200, {
+      schemaVersion: 1,
+      label: 'hey',
+      message: 'yo',
+      namedLogo: 'github',
+      logoSize: 'auto',
+    }),
+  )
+  .after((err, res, body) => {
+    expect(err).not.to.be.ok
+    expect(body).to.include(getSimpleIcon({ name: 'github', logoSize: 'auto' }))
+  })
+
 const logoSvg = Buffer.from(
   getShieldsIcon({ name: 'npm' }).replace('data:image/svg+xml;base64,', ''),
   'base64',