Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github blocks all SVGs in all readmes #112

Closed
feross opened this issue Feb 2, 2014 · 12 comments
Closed

Github blocks all SVGs in all readmes #112

feross opened this issue Feb 2, 2014 · 12 comments

Comments

@feross
Copy link

feross commented Feb 2, 2014

I just noticed all the badges on webtorrent returning 404. Emailed github support and got this response:

Unfortunately we had to disable svg proxying for the time being due to security concerns. I'm currently investigating when svg images will return to the READMEs, but I don't have a solid date at this piont.

:( In the meantime I recommend making png the default on img.shields.io to save lots of people from confusion.

@espadrine
Copy link
Member

That is quite a recent development. Also, I believe GitHub's fear is unfounded. SVG images are very restricted in browsers such as Firefox: scripts cannot run, harsh CORS rules are in place…

I'll try inviting @holman and @vmg to the conversation.

@holman
Copy link

holman commented Feb 2, 2014

SVG caching is disabled at the moment; it'll be coming back.

@feross
Copy link
Author

feross commented Feb 2, 2014

If it helps, the above email was from @atmos

@espadrine
Copy link
Member

@holman Good to know.

On that topic, could SVG also work in relative URLs in Readmes, like PNG does?

See #103 (comment) for more info.

@holman
Copy link

holman commented Feb 2, 2014

On that topic, could SVG also work in relative URLs in Readmes, like PNG does?

It might be something we'd support in the future.

@espadrine
Copy link
Member

On that topic, could SVG also work in relative URLs in Readmes, like PNG does?

It might be something we'd support in the future.

I'd love that. Example use: a code coverage tool that directly produces the badge, and simply links to it on the readme. Right now, using rawgit.luolix.top is the only way, but forks get the wrong information.

@feross
Copy link
Author

feross commented Feb 2, 2014

Update via email:

I'm working through the rollout of trying to reenable SVG support this afternoon. If you can deal with the broken images for a day or two we will likely have them back soon.

@espadrine
Copy link
Member

I believe they have fixed this now. @feross can you confirm?

@feross
Copy link
Author

feross commented Feb 6, 2014

Yep, confirmed.

Feross
✩ blog http://feross.org/ | ✎ studynotes http://www.apstudynotes.org/ |☮
webtorrent http://webtorrent.io/

On Thu, Feb 6, 2014 at 1:58 PM, Thaddee Tyl notifications@git.luolix.topwrote:

I believe they have fixed this now. @feross https://github.com/ferosscan you confirm?


Reply to this email directly or view it on GitHubhttps://github.com//issues/112#issuecomment-34377111
.

@feross
Copy link
Author

feross commented Feb 24, 2014

Looks like GitHub is blocking SVGs again :( See: https://github.com/feross/magnet-uri

@holman, @atmos - can you confirm?

@atmos
Copy link

atmos commented Feb 24, 2014

We haven't changed anything in a week or two. Your best bet is to email support@github.com with the output of curl -vv.

@feross
Copy link
Author

feross commented Feb 24, 2014

Oh, sorry. Looks like an issue with shields.io. I'll open an issue here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants