Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Release Parsing #169

Closed
LeoColomb opened this issue May 3, 2014 · 2 comments · Fixed by #170
Closed

GitHub Release Parsing #169

LeoColomb opened this issue May 3, 2014 · 2 comments · Fixed by #170

Comments

@LeoColomb
Copy link
Contributor

As the GitHub site does, when parsing releases JSON output, Shields should get the more recent release with the created_at tag.
Sometime old releases are "published" after their "creation" (the git tag) and the badge is wrong.

Example: YOURLS Releases / API JSON / Release
@LeoColomb LeoColomb mentioned this issue May 4, 2014
Merged
@espadrine
Copy link
Member

Thanks a lot for a clear explanation of the issue, an example problematic case, and a patch!

@LeoColomb
Copy link
Contributor Author

You're welcome! 😄

segiddins pushed a commit to segiddins/shields that referenced this issue May 21, 2014
@LeoColomb @segiddins
Get latest GitHub release by creation dates comparison
fb56432 
Fixes badges#169
@bnnk bnnk mentioned this issue Mar 10, 2021
Open
@j-sp4 j-sp4 mentioned this issue Mar 11, 2021
Open
@Richienb Richienb mentioned this issue Mar 11, 2021
Closed
@dbalde dbalde mentioned this issue Mar 11, 2021
Open
@snyk-bot snyk-bot mentioned this issue Jul 6, 2021
Merged
@Richienb Richienb mentioned this issue Oct 5, 2022
Closed
@j-sp4 j-sp4 mentioned this issue Oct 6, 2022
Open
@snyk-bot snyk-bot mentioned this issue Oct 6, 2022
Open
@snyk-bot snyk-bot mentioned this issue Apr 8, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get latest GitHub release by creation dates comparison
2 participants
@espadrine @LeoColomb