Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support authentication for private nexus repo #1699

Closed
rockerhieu opened this issue May 23, 2018 · 3 comments · Fixed by #2520
Closed

Support authentication for private nexus repo #1699

rockerhieu opened this issue May 23, 2018 · 3 comments · Fixed by #2520
Labels
good first issue New contributors, join in! service-badge Accepted and actionable changes, features, and bugs

Comments

@rockerhieu
Copy link

I couldn't find a way to use badge for a private nexus repo which requires authentication.

Please troubleshoot. Thanks!

@rockerhieu rockerhieu changed the title Support basic authentication for private nexus repo Support authentication for private nexus repo May 23, 2018
@paulmelnikow
Copy link
Member

Happy to support this. It looks like this will require two things: (1) a small modification to server.js to read the nexus secret from serverSecrets if it exists, and (2) self-hosting an instance of Shields. If you are able to work on that, or if anyone else reading this wants this feature, and you need help moving that forward, feel free to ask here and one of the maintainers can help.

@paulmelnikow paulmelnikow added good first issue New contributors, join in! service-badge Accepted and actionable changes, features, and bugs labels Jun 16, 2018
@rockerhieu
Copy link
Author

Hey @paulmelnikow, let me know the next steps. I'm ready to move forward.

@paulmelnikow
Copy link
Member

Great!

You could take a look at the Jira badge, which pulls the secret value from serverSecrets. You could add code to the Nexus section, also in server.js, to do something similar. You can test it out locally using your authorization information, and open a pull request with the change.

You could also add a test that uses a mock to show that the authorization information is passed to the API as expected, though that might be more effort than it's worth. This is the test code:

https://github.com/badges/shields/blob/def1bc331cf90509e75038c1e1d8681c65aefe8f/services/nexus/nexus.tester.js

There are some general contribution guidelines in https://github.com/badges/shields/blob/master/CONTRIBUTING.md and a lot of step-by-step help in the new badge tutorial https://github.com/badges/shields/blob/master/doc/TUTORIAL.md.

@platan platan added the hacktoberfest Same as "good first issue" label Sep 30, 2018
@platan platan removed hacktoberfest Same as "good first issue" labels Nov 1, 2018
paulmelnikow pushed a commit that referenced this issue Dec 19, 2018
Ports the Nexus service to the new service model. Some related/relevant conversation in #2347 (and closes #2347). Also adds support for authentication which resolves #1699.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue New contributors, join in! service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants