Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packagist version badge outdated #175

Closed
denis-sokolov opened this issue May 13, 2014 · 5 comments
Closed

Packagist version badge outdated #175

denis-sokolov opened this issue May 13, 2014 · 5 comments

Comments

@denis-sokolov
Copy link

The badge for filp/whoops is outdated. It shows 1.1-rc, although the 1.1 has been outed for over two weeks now:

whoops version

Is there anything that can force a refresh on a badge?

@espadrine
Copy link
Member

I get the same version on my local machine, which means it's an algorithmic issue. I would ask you to blame that guy, but it would probably be pointless. He did what seemed the simplest thing you could do: take your package's data, find the stable-looking versions, take the highest one in the default JS string ordering, based on standard lexicographical ordering, using Unicode values.

This means that '1.1-rc' is indeed higher than '1.1', but '1.1' is lower than '1.2'.

We could use semantic versioning to check for which version is highest, but you don't use that, so it wouldn't work anyway.

If you have a better idea, I'm all ears!

@denis-sokolov
Copy link
Author

Today I learned that dropping a patch number is not valid semver. We'll fix that.
Meanwhile, I think you totally should use semantic versioning. To begin with, it just makes sense. But it's also in Packagist/Composer docs, so that's expected to be correct.

@espadrine
Copy link
Member

Today I learned that dropping a patch number is not valid semver. We'll fix that.

Nah, that's valid semver. What isn't is having only two numbers. 1.1.1-rc is valid semver.

@denis-sokolov
Copy link
Author

I think you misunderstood. That's what I said. Patch number is the third number.

@espadrine
Copy link
Member

Ah, right. Gotcha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants