Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges for Semaphore #28

Closed
vlasar opened this issue Apr 10, 2013 · 17 comments
Closed

Badges for Semaphore #28

vlasar opened this issue Apr 10, 2013 · 17 comments
Labels
service-badge Accepted and actionable changes, features, and bugs

Comments

@vlasar
Copy link

vlasar commented Apr 10, 2013

Hello,

I'm working on Semaphore and would like to get it "shielded".

We uses badges for the following build statuses:

  • passing
  • pending
  • failing
  • unknown

Build badges from here:
Shields Badges

suite our color taste but we need a badge for the "unknown" status instead of the "error" status.

Could you create those badges for us or what is the standard workflow?

@olivierlacan
Copy link
Member

@vlasar We worked with @ackerdev to provide developers with a simple way to generate Shields themselves but that work is not anywhere near complet at the moment.

That said we already built an Unknown state badge for the Travis team originally, you're free to use it: https://github.com/olivierlacan/shields/blob/master/travis/travis_unknown.png

@JeanMertz
Copy link

@vlasar any update on this? The current Semaphore badge looks out-of-place compared to all the other "shielded" badges of other services.

@vlasar
Copy link
Author

vlasar commented Sep 27, 2013

We have now added support for shields.io badges on Semaphore. Better late than never. Thank you.

chadwhitacre pushed a commit that referenced this issue Feb 19, 2014
@stevelacey
Copy link

Would be nice if these were updated to match the new badges:

screen shot 2015-02-17 at 12 03 25

@espadrine
Copy link
Member

@stevelacey Are the Semaphore badges not defaulting to the right style? Do they rely on ?style=flat?

@stevelacey
Copy link

@espadrine https://semaphoreapp.com/api/v1/projects/eb289e04-3982-4de1-9e66-8436a67cf607/262663/shields_badge.svg?style=flat doesn't seem to do anything – they self-hosted – so need an update? Dunno – there's a few services with outdated badges though, see https://github.com/crysalead/kahlan

@espadrine
Copy link
Member

Indeed. @vlasar do you have information on that? Do you need help?

@vlasar
Copy link
Author

vlasar commented Feb 17, 2015

I'm no longer working on Semaphore, but I am trying to get in touch with them. cc @markoa

@markoa
Copy link

markoa commented Feb 19, 2015

Hi folks, it looks like it is now expected that shields.io is proxying the badge URLs to the CI service, while on Semaphore we're still hosting the images ourselves. What is the procedure to do it the proxy way?

@espadrine
Copy link
Member

@markoa To avoid having to deal with image updates manually, the simplest way to do is to request the badge from shields.io at https://img.shields.io/badge/build-passing-brightgreen.svg. If possible, supporting the ?style= modifier would be great (eg, https://img.shields.io/badge/build-passing-brightgreen.svg?style=flat-square.)

If you wish to continue to self-host those badges, you can of course download them from shields.io, and update them periodically.

@markoa
Copy link

markoa commented Feb 23, 2015

@espadrine Thanks for the explanation. I think we'll start requesting the badge from shields.io. Would it be useful to post here when we implement it?

@espadrine
Copy link
Member

@markoa Yes! Definitely.

@stevelacey
Copy link

@markos any progress on this?

@markos
Copy link

markos commented Mar 20, 2015

@stevelacey wrong person :)

@stevelacey
Copy link

@markos well that's just unfair! :)

@rastasheep
Copy link

We have updated our badges to match current design used by other services. Unfortunately because we're self-hosting them, optional params for themes are not supported yet, but in future we'll provide that option too.

@paulmelnikow paulmelnikow added service-badge Accepted and actionable changes, features, and bugs and removed needs-upstream-help Not actionable without help from a service provider labels Oct 12, 2017
@NHellFire
Copy link
Contributor

@rastasheep How about redirecting to shields.io (including the query string)? Then we'll have whatever customization shields.io offers. As well as they'll always match other shields badges on the same page (right now Semaphore badges are a slightly different size and text spacing to Shields.io).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

No branches or pull requests

10 participants