Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for customizing badge colors #349

Closed
jgranick opened this issue Jan 10, 2015 · 17 comments
Closed

Add support for customizing badge colors #349

jgranick opened this issue Jan 10, 2015 · 17 comments
Labels
core Server, BaseService, GitHub auth

Comments

@jgranick
Copy link

Hey guys,

I am using the "GitHub" style badge in order to denote the latest release of https://github.com/openfl/openfl on Haxelib.

I would not expect Haxelib to be supported out of the box on shields.io, and the Github badge is working great, except I really would like to customize the color. Could this be added? Something like this:

Haxelib Release

(but orange, using color=orange)

@espadrine
Copy link
Member

Hi!

Badge colors are usually there to emphasize a point (such as, for tests, whether the tests pass). For versions, it distinguishes at a glance major version zero / pre-release (in the semver definition). Orange means that the provided API is unstable. Blue means stable.

We could definitely allow to override that color. Wouldn't it defeat its purpose, though?

@jgranick
Copy link
Author

Ah, I thought it was hard-coded to use blue in order to match GitHub. In general, I believe that the standardized color codes is a good way to go, particularly when coming to build | passed or build | failed it's really clear.

Although it might ordinarily be discouraged, I feel the label value allows the tags to be used in ways, perhaps, they weren't originally intended. For example, it happens that I tag every release we make, so even though haxelib is not a supported type, I've leveraged it to give me what I want, but I didn't realize the significance. I think a color tag could do the same

Another system, "Badge Fury" (for example), uses green for versions, and one could make their badges match if they wanted: http://badge.fury.io

If you added support for doing "GitHub Issues", while specifying a tag name (at first I thought the "issues-raw" example was using a "raw" tag, but I was mistaken) then I would also be interested in replicating a waffle.io badge. By doing a Github Issues badge for issues marked "ready" only, I could recreate their badge. However, in this case, it would be great as well to use a color tag to use their same light blue hue, so it's the same Waffle badge, but flat and modern looking.

I think adding a color tag would lend itself to creative new ways to leverage your existing functionality 😄

@espadrine
Copy link
Member

Waffle support would definitely be great. So far, the issue isn't solved, although sending requests directly to GitHub may solve it.

@nijikokun
Copy link

Badge colors are usually there to emphasize a point (such as, for tests, whether the tests pass). For versions, it distinguishes at a glance major version zero / pre-release (in the semver definition). Orange means that the provided API is unstable. Blue means stable.

What do you mean when you say "API is unstable"

@jgranick
Copy link
Author

From http://semver.org:

Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.

espadrine added a commit that referenced this issue Jan 15, 2015
@zbeekman
Copy link

I would like to be able to have some badge color override too

@dmarcelino
Copy link

👍 for badge color override

@montanaflynn
Copy link

+1

Could work just like the style through a query string such as ?color=brightgreen

@timothyfcook
Copy link

This relates heavily to #401 e.g. there is no ?color=purple option which is necessary for a Heroku deploy button.

@espadrine
Copy link
Member

@timothyfcook Isn't that orthogonal to the issue? We can definitely do this: http://img.shields.io/badge/heroku-deploy-7251C2.svg.

@timothyfcook
Copy link

Cool. That's great. Maybe it's as simple as adding a bit to the Style section to explain that you can use hexadecimal color codes.

@espadrine
Copy link
Member

It's meant to be implicit in the segment on how to build custom badges (see the badge color on the right): http://shields.io/#your-badge

@timothyfcook
Copy link

Just noticed that. Maybe let's highlight it somehow. Very subtle.

@miroswan
Copy link

How would you add color to a downloads badge?

@espadrine
Copy link
Member

There is a PR for overriding colors now: #547

@paulmelnikow paulmelnikow added frontend The React app and the infrastructure that supports it enhancement labels Apr 18, 2017
@paulmelnikow
Copy link
Member

Related: #842

@paulmelnikow
Copy link
Member

@RedSparr0w

@paulmelnikow paulmelnikow added core Server, BaseService, GitHub auth and removed frontend The React app and the infrastructure that supports it labels Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Server, BaseService, GitHub auth
Projects
None yet
Development

No branches or pull requests

9 participants