Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flathub]Add downloads badge #7724

Merged
merged 5 commits into from
May 11, 2022
Merged

[Flathub]Add downloads badge #7724

merged 5 commits into from
May 11, 2022

Conversation

JakobDev
Copy link
Contributor

Closes #5506

@shields-ci
Copy link

shields-ci commented Mar 14, 2022 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @JakobDev!

Generated by 🚫 dangerJS against aff4a41

@JakobDev
Run prettier
be62111 
Signed-off-by: JakobDev <jakobdev@gmx.de>
@calebcartwright
Copy link
Member

Thank you for the PR!

To avoid any bifurcation or loss of discussion for historical context, I'd recommend we first continue/resolve conversation back on the issue (especially the questions in #5506 (comment)) before diving to deeply into the proposed implementation

paulmelnikow added a commit that referenced this pull request Mar 15, 2022
@paulmelnikow
Use new CircleCI "convenience" images
7c23f04 
Closes #7724
@paulmelnikow paulmelnikow mentioned this pull request Mar 15, 2022
Merged
@JakobDev JakobDev mentioned this pull request Mar 25, 2022
Closed
@repo-ranger repo-ranger bot closed this in 203afbc Mar 25, 2022
@calebcartwright
Copy link
Member

This was closed by mistake due to a typo in an unrelated commit message, reopening

@calebcartwright calebcartwright added service-badge Accepted and actionable changes, features, and bugs needs-upstream-help Not actionable without help from a service provider labels Mar 27, 2022
@calebcartwright
Copy link
Member

In a holding pattern for now as the upstream service maintainers have stated they'd like to modify the API response before we start consuming

@JakobDev
Copy link
Contributor Author

JakobDev commented May 8, 2022

@calebcartwright flathub-infra/website#67 has now been merged. I had updated my PR. This PR is now ready to merge.

@chris48s
Copy link
Member

I think this one is good to go. I'll leave it open in cast @calebcartwright wants to chime in before we merge but LGTM

@calebcartwright calebcartwright added squash when passing and removed needs-upstream-help Not actionable without help from a service provider labels May 11, 2022
@repo-ranger repo-ranger bot merged commit 51ebba7 into badges:master May 11, 2022
@JakobDev JakobDev deleted the flathubdownload branch May 11, 2022 05:39
This was referenced May 13, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

@calebcartwright calebcartwright calebcartwright approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Badge request: Flathub downloads
4 participants
@JakobDev @shields-ci @calebcartwright @chris48s