Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jetbrains] badge to show downloads count from jetbrains plugin repository v2 #1025

Merged
merged 7 commits into from
Sep 28, 2017
Merged

[jetbrains] badge to show downloads count from jetbrains plugin repository v2 #1025

merged 7 commits into from
Sep 28, 2017

Conversation

platan
Copy link
Member

@platan platan commented Jul 2, 2017

This pull request is based on @mskonovalov's pull request #896. I've fixed issues reported by @paulmelnikow (badge format + service tests).

@platan platan changed the title badge to show downloads count from jetbrains plugin repository v2 [jetbrains] badge to show downloads count from jetbrains plugin repository v2 Jul 2, 2017
@platan
Copy link
Member Author

platan commented Jul 2, 2017

I've forgotten about adding [jetbrains] to PR name (https://github.com/badges/shields/tree/master/service-tests#pull-requests). I'm not sure if Travis will see changed name. Could you please rerun Travis build?
By the way, maybe all service tests should be run when there is a PR for given branch? This would be less error prone.

@platan
Copy link
Member Author

platan commented Aug 14, 2017

What do you think about this change?

Copy link
Member

@paulmelnikow paulmelnikow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks you for picking up the work from #896. I just restarted the Travis build and things look good.

If you merge master into this branch and fix the merge conflict, I will squash + merge this into master.

@platan
Copy link
Member Author

platan commented Sep 24, 2017

I've merged master. Unfortunately CI build failed, because some GitHub's service tests failed. The same problem occurred in CRON build in master yesterday, 2 days ago, 3 days ago, and so on :-(

@platan
Copy link
Member Author

platan commented Sep 26, 2017

I can see you're working intensively on GitHub rate limit problem #979

@paulmelnikow paulmelnikow merged commit 5278816 into badges:master Sep 28, 2017
@paulmelnikow
Copy link
Member

Much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants