Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose logoBase64 and links in badge-maker NPM package #10283

Merged
merged 5 commits into from
Jun 24, 2024

Conversation

chris48s
Copy link
Member

In this PR, I have picked out the bits of #9645 that were heading in the right direction and fixed them up. I am probably going to just merge this as most of the review has already happened under #9645 but I'll leave it open a few days in case anyone wants to jump in on it.

@chris48s chris48s added the npm-package Badge generation and badge templates label Jun 21, 2024
Copy link
Contributor

github-actions bot commented Jun 21, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @chris48s!
📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against b6b4cc7

PyvesB
PyvesB previously approved these changes Jun 22, 2024
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/badge-maker@4.0.0 None 0 0 B

🚮 Removed packages: npm/badge-maker@3.3.1

View full report↗︎

@chris48s chris48s merged commit 5c81299 into master Jun 24, 2024
38 checks passed
@chris48s chris48s deleted the badge-maker-logoBase64 branch June 24, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm-package Badge generation and badge templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants