-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate [TreewareTrees] service #10466
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe worth leaving this open for a bit to see if the original author responds, but happy for you to merge it when the time is right
What would be the difference with our existing ecologi badges? Have Ecologi and Treeware essentially merged into one project? |
One thing I'll quickly note here is: the treeware badge uses a user/package format whereas the ecologi one takes a username only |
Yeah, so packages with Treeware are recorded by package name (i.e. using the In theory, we could proxy this and add a Or, we can keep this separate badge which nicely encodes specifically for packages (which I think works a bit cleaner). 🤷🏻 And, nope, Ecologi and Treeware are separate. Just Treeware use Ecologi as their service for where trees are purchased. So it uses the Ecologi API behind the scenes. |
Thanks for the additional context! I think it makes sense to leave things as they are and simply switch the API endpoint. I've opened #10467 accordingly. |
The Treeware API has been unresponsive for some time now. I reported the issue a month ago in TreewareEarth/treeware.earth#35, but haven't heard back. Given low usage numbers (43 renders last Thursday for example), I think we can go ahead and start the deprecation process.
Cc @owenvoke who contributed the badge in the first place.