Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate [TreewareTrees] service #10466

Closed
wants to merge 1 commit into from

Conversation

PyvesB
Copy link
Member

@PyvesB PyvesB commented Aug 18, 2024

The Treeware API has been unresponsive for some time now. I reported the issue a month ago in TreewareEarth/treeware.earth#35, but haven't heard back. Given low usage numbers (43 renders last Thursday for example), I think we can go ahead and start the deprecation process.

Cc @owenvoke who contributed the badge in the first place.

@PyvesB PyvesB added the service-badge Accepted and actionable changes, features, and bugs label Aug 18, 2024
Copy link
Contributor

Messages
📖 ✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against c640a79

Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth leaving this open for a bit to see if the original author responds, but happy for you to merge it when the time is right

@owenvoke
Copy link
Contributor

Hi @PyvesB and @chris48s, the Offset Earth platform was renamed to Ecologi.

We should be able to update the offset.earth domain to ecologi.com and it will start working again. 👍🏻

@PyvesB
Copy link
Member Author

PyvesB commented Aug 19, 2024

What would be the difference with our existing ecologi badges? Have Ecologi and Treeware essentially merged into one project?

@chris48s
Copy link
Member

One thing I'll quickly note here is: the treeware badge uses a user/package format whereas the ecologi one takes a username only

@owenvoke
Copy link
Contributor

owenvoke commented Aug 20, 2024

Yeah, so packages with Treeware are recorded by package name (i.e. using the ref query param, which is an MD5 hash of vendor/package).

In theory, we could proxy this and add a ref param to the Ecologi badge (which can actually be used for referencing anyone who has bought trees).

Or, we can keep this separate badge which nicely encodes specifically for packages (which I think works a bit cleaner). 🤷🏻


And, nope, Ecologi and Treeware are separate. Just Treeware use Ecologi as their service for where trees are purchased. So it uses the Ecologi API behind the scenes.

@PyvesB
Copy link
Member Author

PyvesB commented Aug 20, 2024

Thanks for the additional context! I think it makes sense to leave things as they are and simply switch the API endpoint. I've opened #10467 accordingly.

@PyvesB PyvesB closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants