Fix [crates] license badge #1062
Conversation
|
Hi! Thanks for fixing this. Would love to get this merged. Could you add a test? |
|
@paulmelnikow Added a couple tests; let me know if I should make any changes! |
service-tests/crates.js
Outdated
| .get('/l/libc.json') | ||
| .expectJSONTypes(Joi.object().keys({ | ||
| name: Joi.equal('license'), | ||
| value: Joi.not('undefined') |
There was a problem hiding this comment.
Could you just use 'MIT/Apache-2.0' as before? Or, if for some reason this package's license is likely to change, choose a different one?
There was a problem hiding this comment.
Done! I don't anticipate the license to change, since the dual MIT/Apache-2.0 license is pretty standard across Rust projects, and libc is currently the most download crate.
paulmelnikow
added
bug
License data was moved to crate versions in rust-lang/crates.io#803.
|
@paulmelnikow Hmm, I rebased on top of |
|
Those github tests are passing on my machine. So the most likely explanation is that they are also related to #979, in a different manifestation, where the rate limit runs out, affecting some of the requests in the middle of the suite, and not others. It's a little odd that some github tests pass afterward, though some of them are mocked, and others might not be subject to rate limits. |
License data was moved to crate versions in rust-lang/crates.io#803. Closes #1059.