Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website revamp/redesign #1070

Closed
wants to merge 3 commits into from
Closed

Website revamp/redesign #1070

wants to merge 3 commits into from

Conversation

mbrandau
Copy link
Contributor

@mbrandau mbrandau commented Sep 4, 2017

I redesigned the website using Bootstrap 4. Now it's responsive and better looking in my opinion.
If you don't like it, no problem, but I thought the current version needed some changes. 馃槃

Please tell me what you guys think.

desktop
mobile
The design is not quite finished. I thought it would be better to get some opinions in first.

@mbrandau mbrandau closed this Sep 6, 2017
@mbrandau mbrandau reopened this Sep 6, 2017
@paulmelnikow
Copy link
Member

I like it! Seems like a big improvement.

I wonder if it's possible to avoid so many boilerplate classes to the elements for each badge, and also whether the original badge lines could be kept as is, for benefit of the other open PRs.

@paulmelnikow paulmelnikow added the frontend The React app and the infrastructure that supports it label Sep 30, 2017
@paulmelnikow
Copy link
Member

In #1163 I did some work on the code generation for the badge portion of the web page. After that's done it should be much easier to modify the badge rendering independent of the data. I think that, and a more modern frontend build system, would be a nice foundation for a frontend redesign.

In the meantime, could you merge master into this branch so I can deploy a Heroku review app? Might be nice for people to play around with what you've started!

@PyvesB
Copy link
Member

PyvesB commented Oct 14, 2017

This seems like a promising piece of work! Maybe it would be better to put the URL on the same line as the badge and its title, in order to save some space? You seem to fit significantly less badges per screen than the current page does, with the ever growing number of badges the page may become gigantic. Of course that's only my personal opinion, I'm not a maintainer around here. 馃槈

@tooomm
Copy link
Contributor

tooomm commented Dec 9, 2017

Any updates or progress around here?

@wow-apps
Copy link

@tooomm seems not ...
I have an idea to make new UI with new feature 'Create collection' .. I'll create an issue and make pull request in a few weeks )

@paulmelnikow
Copy link
Member

Going to close this for now. For sweeping overhauls, I wonder if we should start with some visual designs? Or possibly starting with some more incremental changes to the user experience?

@PyvesB
Copy link
Member

PyvesB commented Aug 9, 2018

@mbrandau and @wow-apps you seemed to have some promising ideas to improve the homepage, wouldn't you be interested in giving it another shot? 馃槂

@chris48s
Copy link
Member

Given we've refactored the front-end to use ReactJS since this was started, it would probably be quite hard to directly resurrect this PR. That said, one of the other things we have done since this PR was closed is we've decoupled the badge examples from the presentation. That would make something like this much easier to work on and less likely to create conflicts with other ongoing work.

@mbrandau
Copy link
Contributor Author

Just had a quick look at it again. The new frontend seems promising. As @paulmelnikow proposed, I will create an issue and start with some designs.

@mbrandau mbrandau mentioned this pull request Aug 11, 2018
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The React app and the infrastructure that supports it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants