Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update maintenance #1089

Merged
merged 2 commits into from
Sep 25, 2017
Merged

update maintenance #1089

merged 2 commits into from
Sep 25, 2017

Conversation

RedSparr0w
Copy link
Member

Solves #1073
Added test

URL Badge
/maintenance/yes/2017.svg
/maintenance/until end of 2017/2017.svg
/maintenance/no/2017.svg
/maintenance/yes/2016.svg
/maintenance/until end of 2016/2016.svg

@paulmelnikow
Copy link
Member

paulmelnikow commented Sep 25, 2017 •
edited
Loading

Thanks a bunch! Could you fix the lint error and then I'll merge this in?

@paulmelnikow paulmelnikow added bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs labels Sep 25, 2017
@RedSparr0w
Copy link
Member Author

eslint errors fixed!

this PR seems to be failing with

PR: badges/shields#1089
Error: 403 Forbidden

would this be related to #979

@paulmelnikow paulmelnikow merged commit 65d6dc2 into badges:master Sep 25, 2017
@paulmelnikow paulmelnikow mentioned this pull request Oct 2, 2017
Closed
@RedSparr0w RedSparr0w deleted the maintenance branch November 1, 2017 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Bugs in badges and the frontend service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RedSparr0w @paulmelnikow