Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get pull request metadata from shields.io #1120

Merged
merged 1 commit into from
Oct 6, 2017
Merged

Get pull request metadata from shields.io #1120

merged 1 commit into from
Oct 6, 2017

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Oct 2, 2017

Use the endpoint on img.shields.io added in #1114 to fetch the PR title.

This sidesteps the authentication requirement, and helps with #979 – except for PRs that need to run the Github service tests, which will need a separate solution.

#1114 hasn't been deployed, so don't merge yet.

Update: It's now been deployed, so this is good to go.

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Oct 2, 2017
@paulmelnikow paulmelnikow changed the title [do not merge] Get pull request metadata from shields.io Get pull request metadata from shields.io Oct 3, 2017
@paulmelnikow
Copy link
Member Author

If there's a need to revisit this change, I'm happy to do that!

@paulmelnikow paulmelnikow merged commit f3a03c3 into badges:master Oct 6, 2017
@paulmelnikow paulmelnikow deleted the pr-metadata branch October 6, 2017 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant