[amo chrome-web-store wordpress] Enhanced star display #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (decimal >= 0.875) { stars += '★'; } | ||
| else if (decimal >= 0.625) { stars += '¾'; } | ||
| else if (decimal >= 0.375) { stars += '½'; } | ||
| else if (decimal >= 0.125) { stars += '¼'; } | ||
| while (stars.length < 5) { stars += '☆'; } | ||
| return stars; | ||
| } |
There was a problem hiding this comment.
Could you add unit tests of this function, like the ones for maybePluralize in https://github.com/badges/shields/blob/master/lib/text-formatters.spec.js? The tests make it easy to verify it's doing what's expected and intended, and prevent regressions in case someone needs to change this in the future.
There was a problem hiding this comment.
I had missed out on that file. Will fix it.
| @@ -11,7 +11,7 @@ const isVPlusTripleDottedVersion = withRegex(/^v[0-9]+.[0-9]+.[0-9]+$/); | |||
|
|
|||
| const isVPlusDottedVersionAtLeastOne = withRegex(/^v\d+(\.\d+)?(\.\d+)?$/); | |||
|
|
|||
| const isStarRating = withRegex(/^[\u2605\u2606]{5}$/); | |||
| const isStarRating = withRegex(/^(?=.{5}$)(\u2605{0,5}[\u00BC\u00BD\u00BE]?\u2606{0,5})$/); | |||
|
Ace. Thanks! |
|
Ran all the service tests locally on this branch plus #1118, and got two unrelated timeouts: |
paulmelnikow
added
service-badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another follow up pull request, related to some discussions in #1177.
Brief outline of the problem, for people who haven't read the previous comments. The
starRatingmethod was previously displaying stars floored to the nearest integer. If 4.99 was passed in as an argument, it would display ★★★★☆. Even if the value was rounded before passing it as an argument (this was done for the Chrome badges), values such as 4.49 would be brought down to ★★★★☆, which seems rough.This pull request attempts to solve the problem by making use of three additional UTF-8 characters. Badges will now display ratings such as the following:
Again, lacking UTF-8 characters such as half stars is not ideal, but this is a trade-off between having a badge that looks perfect and having a badge that actually conveys meaningful information. 🌟
Cheers,
Pyves