Retire try.html and various frontend cleanup #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulmelnikow
commented
Oct 21, 2017
Makefile
Outdated
| cat frontend/fragments/try-header.html build/badge-examples-fragment.html frontend/fragments/try-footer.html > try.html && \ | ||
| cat try.html | $(SED) "s,(<img src=')(/[^'\?]+)',\1https://img.shields.io\2?maxAge=2592000'," \ | ||
| cat frontend/fragments/try-header.html build/badge-examples-fragment.html frontend/fragments/try-footer.html \ | ||
| | $(SED) "s,(<img src=')(/[^'\?]+)',\1https://img.shields.io\2?maxAge=2592000'," \ | ||
| | $(SED) "s,(<img src=')(/[^'\?]+\?[^']+)',\1https://img.shields.io\2\&maxAge=2592000'," \ | ||
| | $(SED) "s,<span id='imgUrlPrefix'>,&https://img.shields.io," \ |
There was a problem hiding this comment.
Would be nice to make handle this in code, with a flag that indicates a dev or production build.
There was a problem hiding this comment.
It's clear that a flag needs to happen before this can be merged. These sed transforms shouldn't happen in development.
# Conflicts: # Makefile # try.html
This was referenced Oct 25, 2017
- Move config for badge examples into the JS build
- Move the prod transform into npm scripts
- I had trouble setting environment variables in make, and while I don’t love this it seems simpler than wrestling with make.
- In the future this could be handled using a bundler plugin
- make website builds production build as before
- It’s portable and tested, and sed in the package.json is not
|
This is looking pretty good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup from #1163