-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Homepage - Styles #1242
Update Homepage - Styles #1242
Conversation
Nice! Could you confirm (on here) that Red$parr0w on Discord is you? And then DM me your email address? I'd like to set you up to deploy review apps from Heroku. |
frontend/fragments/try-footer.html
Outdated
@@ -90,7 +90,7 @@ <h2 id="styles"> Styles </h2> | |||
<td><code>https://img.shields.io/badge/style-flat--squared-green.svg?style=flat-square</code></td> | |||
</tr> | |||
<tr> | |||
<td><img src="/badge/style-for--the--badge-green.svg?style=for-the-badge" alt=''/></td> | |||
<td><img src="/badge/style-for--the--badge-green.svg?style=for-the-badge" alt='' style='height:28px;'/></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. Why is this needed? Are the images fixed height? Would height:auto
work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty much all the images are height:20px
I could change this badge to height:auto
if you like though.
From memory the change to height:20px
was due to the page used to jump around a lot while loading.
Edit: Reduce page jumping while all the badges are loading #967 & #813
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah, thanks for explaining. I remember that change and it makes sense now.
<option value='flat' selected>flat</option> | ||
<option value='flat-square'>flat-square</option> | ||
<option value='for-the-badge'>for-the-badge</option> | ||
<option value='social'>social</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
👍 |
Thanks for taking care of this @RedSparr0w ! 👍
Is the new |
Oh did not even think about that, thanks! |
@RedSparr0w I invited you to the Heroku app so you should be able to deploy review apps now! Let me know how you make out with that. |
Thanks, think that worked, although it says you deployed it so not 100% sure? Couple quick questions, |
Haha, that's funny! No, I did not deploy it. It will automatically re-deploy when you update the PR. And it'll turn itself off when the PR closes, or after I think 30 days. |
updated the css to be |
Looks good to me! |
Closes #1206
IMO it looks a little strange, but makes sense to display it the real size
Added
social
&for-the-badge
style to badge creation dropdown list& close
<option>
tags