Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Homepage - Styles #1242

Merged
merged 3 commits into from
Nov 8, 2017
Merged

Update Homepage - Styles #1242

merged 3 commits into from
Nov 8, 2017

Conversation

RedSparr0w
Copy link
Member

Closes #1206
image
IMO it looks a little strange, but makes sense to display it the real size

Added social & for-the-badge style to badge creation dropdown list
& close <option> tags
image

@paulmelnikow
Copy link
Member

Nice!

Could you confirm (on here) that Red$parr0w on Discord is you? And then DM me your email address? I'd like to set you up to deploy review apps from Heroku.

@paulmelnikow paulmelnikow added the frontend The React app and the infrastructure that supports it label Nov 2, 2017
@@ -90,7 +90,7 @@ <h2 id="styles"> Styles </h2>
<td><code>https://img.shields.io/badge/style-flat--squared-green.svg?style=flat-square</code></td>
</tr>
<tr>
<td><img src="/badge/style-for--the--badge-green.svg?style=for-the-badge" alt=''/></td>
<td><img src="/badge/style-for--the--badge-green.svg?style=for-the-badge" alt='' style='height:28px;'/></td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh. Why is this needed? Are the images fixed height? Would height:auto work?

Copy link
Member Author

@RedSparr0w RedSparr0w Nov 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty much all the images are height:20px
image
I could change this badge to height:auto if you like though.

From memory the change to height:20px was due to the page used to jump around a lot while loading.

Edit: Reduce page jumping while all the badges are loading #967 & #813

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could update the css in try-header to remove .badge-img img which would only affect the following sections:
image
image

table.badge > tbody > tr > td > img, #copyImg {
  height: 20px;
  vertical-align: middle;
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, thanks for explaining. I remember that change and it makes sense now.

<option value='flat' selected>flat</option>
<option value='flat-square'>flat-square</option>
<option value='for-the-badge'>for-the-badge</option>
<option value='social'>social</option>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@RedSparr0w
Copy link
Member Author

RedSparr0w commented Nov 2, 2017

👍 Red$parr0w on discord is me

@tooomm
Copy link
Contributor

tooomm commented Nov 2, 2017

Thanks for taking care of this @RedSparr0w ! 👍

Added social & for-the-badge style to badge creation dropdown list

Is the new for the badge style option there also previewed in its real size?
There is no heroku review app available for this pr to verify for myself.

@RedSparr0w
Copy link
Member Author

Oh did not even think about that, thanks!
Will update it soon with those changes.

@paulmelnikow
Copy link
Member

@RedSparr0w I invited you to the Heroku app so you should be able to deploy review apps now! Let me know how you make out with that.

@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-1242 November 3, 2017 21:19 Inactive
@RedSparr0w
Copy link
Member Author

Thanks, think that worked, although it says you deployed it so not 100% sure?

Couple quick questions,
Do I have to redeploy each time a new commit is pushed through or will it automatically update the deployment?
Once a PR is merged will it automatically stop or does it have to be done manually?

@paulmelnikow
Copy link
Member

Haha, that's funny! No, I did not deploy it.

It will automatically re-deploy when you update the PR.

And it'll turn itself off when the PR closes, or after I think 30 days.

@RedSparr0w
Copy link
Member Author

updated the css to be min-height: 20px; for the badges instead of fixed height: 20px this way all the for-the-badge style badges should be shown at full size without any inline css and the page shouldn't jump around too much

@RedSparr0w
Copy link
Member Author

Should be ready for merge now:
image
Unless there is anything else i've missed.

@paulmelnikow
Copy link
Member

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend The React app and the infrastructure that supports it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new "for the badge" style preview wrong size
3 participants