-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[travis] Get tested PHP version from Travis CI #1255
Conversation
Hi, thanks for this. I appreciate what you're trying to do here. The implementation is pretty involved. Would reading values from It seems like a tests | success, from Travis API, in conjunction with PHP | 7.1, from |
I can make a separate badge which will read data only from |
If the tests are configured for three versions, and the tests pass, logically it implies that the tests pass on those three versions. The difference between that and a post facto guarantee seems pedantic. It's just a badge, not a deploy trigger.
Is the PHP-Eye Travis data different from what you're extracting in #1258? |
As far as i can tell, Yes. They check the result of starting the build. |
After merge #1258, i can simplify this implementation and, for example, rename it to Tested. In my opinion this is simpler and more obvious than: |
Okay, so #1258 is now merged. I appreciate the work you put into that, and into this. Though the endpoint from #1258 for "Tested versions based on Travis" is not perfect, as you've observed, it's good enough, given the "perfect" implementation would need to make several requests. If you can pull the data you want more simply from PHP-Eye I'd certainly be open to that. Also, to adding Composer if you'd like. Thanks again! |
@paulmelnikow I'll definitely make a badge for PHP-Eye and I'll redo this badge when i have time. |
Thanks for understanding! |
For issue #819
In this PR i add badge for get PHP version only from Travis CI.
Also need to add a badges for get version from Composer and PHP-Eye.
I plan to make it separate PR.
I added tests, but they are dangerous.
The success of the tests depends on Symfony.
If you have any ideas how to fix this problem, tell me please.