webpage: add missing titles + more badge previews #1305

tooomm · 2017-12-01T15:23:53Z

Node 9 support (#1290)
over
Github rate limits cause transient service test failures in CI (#979)

Was messing around with the layout due to the very wide column needed:

~~Follow-up commit will fix tests (editing from web).~~

`Node 9 support` (#1290) over `Github rate limits cause transient service test failures in CI` (#979)

tooomm · 2017-12-01T15:31:18Z

Shouldn't the first commit fail? :)

paulmelnikow · 2017-12-01T15:59:07Z

I think this was already fixed in #1297. You can see what it looks like here:
https://shields-staging.herokuapp.com/

The tests and the example page are independent. They don't need to match.

tooomm · 2017-12-01T16:08:50Z

From #1297 (review)

This badge is really wide. Omitting previewUri prevents the badge from displaying and growing the column too wide.

Isn't that more of a workaround instead a fix? ;)
Not having a preview at all feels bad. That's a very important part of the shields site, no?
If you agree, I would switch it back to previewUri for that one (with the shorter issue).

From shields-staging.herokuapp.com:

(There are several badges having no description/headline, too!)

The tests and the example page are independent. They don't need to match.

Makes sense, the test itself is still valid. For me it sounds more logical to match them though.

paulmelnikow · 2017-12-01T18:27:55Z

Eh, it's the same workaround as several of the other long badges.

I do think they should all have a title / headline…

tooomm · 2017-12-01T22:27:05Z

Eh, it's the same workaround as several of the other long badges.

TeamCity (full build status) is the only other one which seems to be missing a badge preview.
Problem there is that you can't even enter preview mode at all if you try to click the example link.
~~Edit: there is Issue Stats (long form) and Pull Request Stats (long form) missing preview badges too.~~ fixed in 3cb6270

I do think they should all have a title / headline…

Tried to fix that. Hope I hit all. Please double check, or could you deploy to Heroku review apps?
Edit: my second pass should catch all!

tooomm · 2017-12-01T22:41:25Z

lib/all-badge-examples.js

        previewUri: '/issuestats/p/github/expressjs/express.svg'
      },
      {
-        title: '(long form)',
+        title: 'Pull Request Stats (long form)',
        exampleUri: '/issuestats/p/long/github/expressjs/express.svg'


I changed the title here to match what the badge is showing.

Example badge shows: pull closure | 16 hrs

paulmelnikow · 2017-12-01T22:43:26Z

TeamCity (full build status) is the only other one which seems to be missing a badge preview.
Problem there is that you can't even enter preview mode at all if you try to click the example link.

Hmm, it seems to be working on current staging:

tooomm · 2017-12-01T22:52:38Z

Not for me:

Clicking on either the name, the non-existant preview or the example link on the right doesn't open that window.
Actually it's not working for all other badges too! (Have a look at the shortened links all are displaying!)

paulmelnikow · 2017-12-01T23:02:40Z

Same here on the PR branch. You might try merging master into this one. Probably one of my recent commits fixed it.

To clarify:

Working: https://shields-staging.herokuapp.com/
Not working: https://shields-staging-pr-1305.herokuapp.com/

tooomm · 2017-12-01T23:04:37Z

Can I request you to do so, please @paulmelnikow ?
I can only use the web interface right now.
done

tooomm · 2017-12-01T23:44:33Z

Working: https://shields-staging.herokuapp.com
Not working: https://shields-staging-pr-1305.herokuapp.com

I'm sorry, but both have the same problem for me. Even after merging most recent badges/shields master to my fork (and this branch).
Neither open the preview window where you can do adjustments to the badge.

Edit: This is a Firefox and Edge problem... (using FF57 and Edge 41), on chromium it opens the preview! 🙈

Also, #1309 applies to both links and all 3 browsers!

those example badges are actually not that big compared to others in that category

tooomm · 2017-12-04T15:36:41Z

No empty titles anymore and all preview badges show.
(except that very big one for TeamCity (full build status) )

Last several comments are basically not relevant anymore due to #1322.

Can you revisit this @paulmelnikow?

paulmelnikow · 2017-12-04T23:58:50Z

I'm fine with the badge changes, though the test change doesn't seem necessary. It's not necessary to keep them perfectly in sync.

This reverts commit 03389f8.

This simplifies and further optimizes text-width computation by computing the entire width table in advance, and serializing it in the style of QuickTextMeasurer (#1390). This entirely removes the need for PDFKit at runtime. This has the advantage of fixing #1305 – more generally: producing the same result everywhere – without having to deploy a copy of Verdana. The lifting is delegated to these three libraries, which are housed in a monorepo: https://github.com/metabolize/anafanafo I'd be happy to move it into the badges org if folks want to collaborate on maintaining them. QuickTextMeasurer took kerning pairs into account, whereas this implementation does not. I was thinking kerning would be a necessary refinement, though this seems to work well enough. I dropped in a binary-search package to traverse the data structure, in part to conserve space. This causes a moderate performance regression, though there is ample room for improving on that: #2311 (comment)

tooomm added 2 commits December 1, 2017 16:21

change to shorter example

ce14488

`Node 9 support` (#1290) over `Github rate limits cause transient service test failures in CI` (#979)

fix tests

03389f8

paulmelnikow added the frontend The React app and the infrastructure that supports it label Dec 1, 2017

fix titles + revert to previewUri

d10597d

more title fixes

0c3c24d

paulmelnikow temporarily deployed to shields-staging-pr-1305 December 1, 2017 22:40 Inactive

tooomm commented Dec 1, 2017

View reviewed changes

Merge branch 'master' into patch-2

1c12e98

paulmelnikow temporarily deployed to shields-staging-pr-1305 December 1, 2017 23:32 Inactive

tooomm changed the title ~~webpage: change to shorter example~~ webpage: add missing titles + exchange github issue title example badge Dec 1, 2017

example to preview

3cb6270

those example badges are actually not that big compared to others in that category

paulmelnikow temporarily deployed to shields-staging-pr-1305 December 2, 2017 14:12 Inactive

tooomm changed the title ~~webpage: add missing titles + exchange github issue title example badge~~ webpage: add missing titles + enable more example badges Dec 2, 2017

tooomm changed the title ~~webpage: add missing titles + enable more example badges~~ webpage: add missing titles + more badge previews Dec 2, 2017

tooomm mentioned this pull request Dec 2, 2017

issues with new frontend rewrite #1311

Closed

2 tasks

espadrine force-pushed the master branch from 203d6d5 to 7e668c7 Compare December 3, 2017 18:06

paulmelnikow mentioned this pull request Dec 4, 2017

Fix and refactor front-end URL generation #1322

Merged

Merge branch 'master' into patch-2

ff06f3a

paulmelnikow temporarily deployed to shields-staging-pr-1305 December 4, 2017 15:20 Inactive

Revert "fix tests"

45a16c5

This reverts commit 03389f8.

paulmelnikow deployed to shields-staging-pr-1305 December 5, 2017 11:39 View deployment

paulmelnikow merged commit f700502 into badges:master Dec 5, 2017

tooomm deleted the patch-2 branch December 5, 2017 16:18

paulmelnikow mentioned this pull request Nov 13, 2018

Precompute text width using a lookup table #2311

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

webpage: add missing titles + more badge previews #1305

webpage: add missing titles + more badge previews #1305

tooomm commented Dec 1, 2017 •

edited

Loading

tooomm commented Dec 1, 2017

paulmelnikow commented Dec 1, 2017

tooomm commented Dec 1, 2017 •

edited

Loading

paulmelnikow commented Dec 1, 2017

tooomm commented Dec 1, 2017 •

edited

Loading

tooomm Dec 1, 2017

paulmelnikow commented Dec 1, 2017

tooomm commented Dec 1, 2017

paulmelnikow commented Dec 1, 2017 •

edited

Loading

tooomm commented Dec 1, 2017 •

edited

Loading

tooomm commented Dec 1, 2017 •

edited

Loading

tooomm commented Dec 4, 2017 •

edited

Loading

paulmelnikow commented Dec 4, 2017

webpage: add missing titles + more badge previews #1305

webpage: add missing titles + more badge previews #1305

Conversation

tooomm commented Dec 1, 2017 • edited Loading

tooomm commented Dec 1, 2017

paulmelnikow commented Dec 1, 2017

tooomm commented Dec 1, 2017 • edited Loading

paulmelnikow commented Dec 1, 2017

tooomm commented Dec 1, 2017 • edited Loading

tooomm Dec 1, 2017

Choose a reason for hiding this comment

paulmelnikow commented Dec 1, 2017

tooomm commented Dec 1, 2017

paulmelnikow commented Dec 1, 2017 • edited Loading

tooomm commented Dec 1, 2017 • edited Loading

tooomm commented Dec 1, 2017 • edited Loading

tooomm commented Dec 4, 2017 • edited Loading

paulmelnikow commented Dec 4, 2017

tooomm commented Dec 1, 2017 •

edited

Loading

tooomm commented Dec 1, 2017 •

edited

Loading

tooomm commented Dec 1, 2017 •

edited

Loading

paulmelnikow commented Dec 1, 2017 •

edited

Loading

tooomm commented Dec 1, 2017 •

edited

Loading

tooomm commented Dec 1, 2017 •

edited

Loading

tooomm commented Dec 4, 2017 •

edited

Loading