Improve search performance #1385
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change applies a unique ID to each badge example, and uses that to key the DOM. Before this change, the key was the array index. While constant with the filter, it mutated as the filter changed, causing React to mutate the DOM very inefficiently. Badges were filtered out by mutating al the rows instead of simply removing the affected rows. I first tried a version that applied a class with `display: none` to the hidden elements. That worked; however the implementation has a bunch of indirection, and this works nearly as well.
Generated by 🚫 dangerJS |
|
Would appreciate some testing vs https://shields.io/ and https://shields-staging.herokuapp.com/! |
|
In my testing, https://shields.io/ is still faster, though https://shields-staging-pr-1385.herokuapp.com/ is much faster than https://shields-staging.herokuapp.com/. |
|
1 thing i noticed that makes it feel slower is the images reloading when you remove letters: I think that gives the |
|
Yea, agreed, that isn't great. However I don't believe it would happen in production, where |
|
I pushed the other branch if you'd like to compare: #1393. |
|
Closing in favor of #1393. |
This was referenced Aug 18, 2021
This was referenced Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change applies a unique ID to each badge example, and uses that to key the DOM.
Before this change, the key was the array index. While constant with the filter, it mutated as the filter changed, causing React to mutate the DOM very inefficiently. Badges were filtered out by mutating al the rows instead of simply removing the affected rows.
I first tried a version that applied a class with
display: noneto the hidden elements. That worked; however the implementation has a bunch of indirection, and this works nearly as well.Fix #1314