[travis php-eye jenkins] Use github auth in php-v badges #1403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Dry getPhpReleases()
- Pass named options to regularUpdate
- Add json option
- php-version: Move helpers before functions, and move exports to end
Generated by 🚫 dangerJS |
paulmelnikow
commented
Dec 28, 2017
| if (err != null) { cb(err); return; } | ||
| if (regularUpdateCache[url] == null) { | ||
| regularUpdateCache[url] = { timestamp: 0, data: 0 }; |
There was a problem hiding this comment.
These lines didn't make sense to me.
There was a problem hiding this comment.
Doesn't looks like it does anything to me.
paulmelnikow
added
the
service-badge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1359