add tests for [hackage]

server.js

@@ -3399,11 +3399,11 @@ cache(function(data, match, sendBadge, request) {
   var apiUrl = 'https://hackage.haskell.org/package/' + repo + '/' + repo + '.cabal';
   var badgeData = getBadgeData('hackage', data);
   request(apiUrl, function(err, res, buffer) {
-    if (err != null) {
-      badgeData.text[1] = 'inaccessible';
+    if (checkErrorResponse(badgeData, err, res)) {
       sendBadge(format, badgeData);
       return;
     }
+
     try {
       var lines = buffer.split("\n");
       var versionLines = lines.filter(function(e) {
@@ -3426,31 +3426,45 @@ cache(function(data, match, sendBadge, request) {
 // Hackage dependencies version integration.
 camp.route(/^\/hackage-deps\/v\/(.*)\.(svg|png|gif|jpg|json)$/,
 cache(function(data, match, sendBadge, request) {
-  var repo = match[1];  // eg, `lens`.
-  var format = match[2];
-  var apiUrl = 'http://packdeps.haskellers.com/feed/' + repo;
-  var badgeData = getBadgeData('hackage-deps', data);
-  request(apiUrl, function(err, res, buffer) {
-    if (err != null) {
-      badgeData.text[1] = 'inaccessible';
+  const repo = match[1];  // eg, `lens`.
+  const format = match[2];
+  const reverseUrl = 'http://packdeps.haskellers.com/reverse/' + repo;
+  const feedUrl = 'http://packdeps.haskellers.com/feed/' + repo;
+  const badgeData = getBadgeData('dependencies', data);
+
+  // first call /reverse to check if the package exists
+  // this will throw a 404 if it doesn't
+  request(reverseUrl, function(err, res, buffer) {
+    if (checkErrorResponse(badgeData, err, res)) {
       sendBadge(format, badgeData);
       return;
     }
 
-    try {
-      var outdatedStr = "Outdated dependencies for " + repo + " ";
-      if (buffer.indexOf(outdatedStr) >= 0) {
-        badgeData.text[1] = 'outdated';
-        badgeData.colorscheme = 'orange';
-      } else {
-        badgeData.text[1] = 'up to date';
-        badgeData.colorscheme = 'brightgreen';
+    // if the package exists, then query /feed to check the dependencies
+    request(feedUrl, function(err, res, buffer) {
+      if (err != null) {
+        badgeData.text[1] = 'inaccessible';
+        sendBadge(format, badgeData);
+        return;
       }
-    } catch(e) {
-      badgeData.text[1] = 'invalid';
-    }
-    sendBadge(format, badgeData);
+
+      try {
+        const outdatedStr = "Outdated dependencies for " + repo + " ";
+        if (buffer.indexOf(outdatedStr) >= 0) {
+          badgeData.text[1] = 'outdated';
+          badgeData.colorscheme = 'orange';
+        } else {
+          badgeData.text[1] = 'up to date';
+          badgeData.colorscheme = 'brightgreen';
+        }
+      } catch(e) {
+        badgeData.text[1] = 'invalid';
+      }
+      sendBadge(format, badgeData);
+    });
+
   });
+
 }));
 
 // Elm package version integration.

service-tests/hackage.js

@@ -0,0 +1,50 @@
+'use strict';
+
+const Joi = require('joi');
+const ServiceTester = require('./runner/service-tester');
+
+const { isVPlusDottedVersionAtLeastOne } = require('./helpers/validators');
+
+const t = new ServiceTester({ id: 'hackage', title: 'Hackage' });
+module.exports = t;
+
+
+t.create('hackage version (valid)')
+  .get('/v/lens.json')
+  .expectJSONTypes(Joi.object().keys({
+    name: 'hackage',
+    value: isVPlusDottedVersionAtLeastOne,
+  }));
+
+t.create('hackage deps (valid)')
+  .get('-deps/v/lens.json')
+  .expectJSONTypes(Joi.object().keys({
+    name: 'dependencies',
+    value: Joi.string().regex(/^(up to date|outdated)$/),
+  }));
+
+t.create('hackage version (not found)')
+  .get('/v/not-a-package.json')
+  .expectJSON({name: 'hackage', value: 'not found'});
+
+t.create('hackage version (not found)')
+  .get('-deps/v/not-a-package.json')
+  .expectJSON({name: 'dependencies', value: 'not found'});
+
+t.create('hackage version (connection error)')
+  .get('/v/lens.json')
+  .networkOff()
+  .expectJSON({name: 'hackage', value: 'inaccessible'});
+
+t.create('hackage deps (connection error)')
+  .get('-deps/v/lens.json')
+  .networkOff()
+  .expectJSON({name: 'dependencies', value: 'inaccessible'});
+
+t.create('hackage version (unexpected response)')
+  .get('/v/lens.json')
+  .intercept(nock => nock('https://hackage.haskell.org')
+    .get('/package/lens/lens.cabal')
+    .reply(200, "")
+  )
+  .expectJSON({name: 'hackage', value: 'invalid'});