-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cauditor] Replace with error message #1502
Conversation
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Indeed, as per this issue, the service seems to have been down for quite a while now. 😉
Thanks for reviewing @PyvesB 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great for me.
Here https://www.mullie.eu/projects/ is some information about Cauditor "Cauditor is currently offline - I got tired of the AWS bills :)", written 8 month ago |
Let's switch this to |
I think it uses |
Ah, that's probably right! I couldn't remember what our default was. |
I have also updated it to use setBadgeColor(badgeData, 'lightgray'); instead of badgeData.colorscheme = 'lightgray'; As this will override any choice of color the user makes with lightgray. Do you think that's the right choice, or still fulfill the users preferred color? |
Sounds good to me! |
Wait to merge until discussions in #1449 resolved.
Cauditor seems to no longer be a service:
cauditor.org
github - hasn't been updated since 2016