Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cauditor] Replace with error message #1502

Merged
merged 3 commits into from
Mar 5, 2018

Conversation

RedSparr0w
Copy link
Member

Wait to merge until discussions in #1449 resolved.

Cauditor seems to no longer be a service:
cauditor.org
github - hasn't been updated since 2016

@shields-ci
Copy link

shields-ci commented Feb 15, 2018

Messages
📖

✨ Thanks for your contribution to Shields, @RedSparr0w!

📖

Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS

@RedSparr0w RedSparr0w added the service-badge Accepted and actionable changes, features, and bugs label Feb 15, 2018
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Indeed, as per this issue, the service seems to have been down for quite a while now. 😉

@RedSparr0w
Copy link
Member Author

Thanks for reviewing @PyvesB 😄

Copy link
Member

@platan platan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for me.

@platan
Copy link
Member

platan commented Feb 25, 2018

Here https://www.mullie.eu/projects/ is some information about Cauditor "Cauditor is currently offline - I got tired of the AWS bills :)", written 8 month ago
https://github.com/matthiasmullie/matthiasmullie.github.io/blame/cc55e21859cd6bb2b01d80afcf5adb42d9f39525/projects.html#L24

@paulmelnikow
Copy link
Member

Let's switch this to lightgray and merge!

@RedSparr0w
Copy link
Member Author

I think it uses lightgray by default,
But will update it to explicitly use lightgray in case the default color changes in the future.
Will also update the test, to test for color.

@paulmelnikow
Copy link
Member

Ah, that's probably right! I couldn't remember what our default was.

@RedSparr0w
Copy link
Member Author

I have also updated it to use

setBadgeColor(badgeData, 'lightgray');

instead of

badgeData.colorscheme = 'lightgray';

As this will override any choice of color the user makes with lightgray.
Thought process being they will notice the non colored badge and remove it.

Do you think that's the right choice, or still fulfill the users preferred color?

@paulmelnikow
Copy link
Member

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants