Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds TeamCity CodeBetter build badge #164

Merged
merged 1 commit into from
Apr 23, 2014
Merged

Conversation

avanderhoorn
Copy link
Contributor

This PR adds TeamCity CodeBetter build badge. For those who aren't familiar:

TeamCity is the primary build server for the Microsoft development platform including .NET. CodeBetter hosts TeamCity for the majority of OSS projects in the Microsoft development platform including .NET.

I've followed the conventions used by the other badges/shields and used npm's as a base for this one.

If there is anything you need changed or added let me know.

@espadrine
Copy link
Member

It might not be a bother, but the URL looks like it might have DSL syntax. Is there a case where buildType should be escaped?

@avanderhoorn
Copy link
Contributor Author

I think its ok, but you can see what they have here. I think that the only option within the id section. But if we want to be safe, it can easily escaped.

@avanderhoorn
Copy link
Contributor Author

Actually that said, you can see there are a few other options here.

@espadrine
Copy link
Member

Ah, ok, it is indeed pretty safe. Is the build ID unique to every single build, or is it the same for all builds in the same project?

@avanderhoorn
Copy link
Contributor Author

Here is what the textbook says:

id: - use internal build id when you need to refer to a specific build

Its unique per build profile. A given project can have multiple build profiles (i.e. CI, nightly, etc).

@espadrine espadrine merged commit acfe2ac into badges:master Apr 23, 2014
@espadrine
Copy link
Member

I'm rather fine with this. Merged. Thanks a lot!

@avanderhoorn
Copy link
Contributor Author

Not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants