Adds puppet forge (versioning) support. #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that! Is there a functional use to having both Also, you left a debugger statement on line 977. |
|
There is no functional use in having both. I changed it to use only puppetforge. You never know there is something else puppety that could use badges. The changes have been made and rebased. |
|
Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mind you, I've never done any node-js development so its pretty much bits and pieces copied from current implementations.
You also might need to reach out to @puppetlabs to finalize and document their forge api. Currently it is (afaik) only used by their internal puppet-module tool which interacts with it for package installations.