Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix [bundlephobia] tests and rm errant inspectJSON #1798

Merged
merged 2 commits into from
Jul 25, 2018
Merged

Fix [bundlephobia] tests and rm errant inspectJSON #1798

merged 2 commits into from
Jul 25, 2018

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Jul 23, 2018 •
edited
Loading

I’m guessing something has changed with the way rounding happens in bundlephobia. I don’t expect this to happen again, but if it does we can change this to a regex.

For #1359

@paulmelnikow
Fix bundlephobia tests and rm errant inspectJSON
b0aced5 
I’m guessing something has changed with the way rounding happens in bundlephobia. I don’t expect this to happen again, but if it does we can change this to a regex.
@paulmelnikow paulmelnikow added the service-badge Accepted and actionable changes, features, and bugs label Jul 23, 2018
@shields-ci
Copy link

shields-ci commented Jul 23, 2018 •
edited
Loading

Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

PyvesB
PyvesB approved these changes Jul 25, 2018
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, our isFileSize validator will come in handy if the tests break again. 😉

@paulmelnikow paulmelnikow merged commit fd58a5b into badges:master Jul 25, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. Now this change is waiting for deployment.
Deploys usually happen every few weeks. After deployment changes are copied to gh-pages branch.

This badge displays deployment status:

@paulmelnikow paulmelnikow deleted the service-test-cleanup-2 branch July 25, 2018 18:46
@paulmelnikow
Copy link
Member Author

Thanks for reviewing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paulmelnikow @shields-ci @PyvesB