Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests by prefix e.g. [librariesio] #1933

Merged
merged 4 commits into from
Aug 19, 2018
Merged

Run tests by prefix e.g. [librariesio] #1933

merged 4 commits into from
Aug 19, 2018

Conversation

paulmelnikow
Copy link
Member

@paulmelnikow paulmelnikow commented Aug 17, 2018 •
edited
Loading

This is a fix for #1923 which it seems to me will work well. It also plays well with #1932.

@paulmelnikow paulmelnikow added the developer-experience Dev tooling, test framework, and CI label Aug 17, 2018
@shields-ci
Copy link

shields-ci commented Aug 17, 2018 •
edited
Loading

Messages
📖

✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS

@paulmelnikow paulmelnikow mentioned this pull request Aug 17, 2018
Merged
PyvesB
PyvesB reviewed Aug 18, 2018
View reviewed changes
Copy link
Member

@PyvesB PyvesB left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we guard against empty strings? If my understanding is correct, if someone mistakenly adds an extra space (e.g. [github appveyor ]), it will try running all the services?

@paulmelnikow
Copy link
Member Author

Updated, though hopefully that's going away in #1936!

@paulmelnikow paulmelnikow mentioned this pull request Aug 18, 2018
Closed
@paulmelnikow paulmelnikow merged commit 365f2cf into badges:master Aug 19, 2018
@shields-deployment
Copy link

This pull request was merged to master branch. Now this change is waiting for deployment.
Deploys usually happen every few weeks. After deployment changes are copied to gh-pages branch.

This badge displays deployment status:

@paulmelnikow paulmelnikow deleted the family-tests branch August 19, 2018 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PyvesB PyvesB PyvesB approved these changes

Assignees
No one assigned
Labels
developer-experience Dev tooling, test framework, and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmelnikow @shields-ci @PyvesB